Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New version of cl-base64, update source repo #1825

Open
phmarek opened this issue Apr 7, 2020 · 11 comments
Open

New version of cl-base64, update source repo #1825

phmarek opened this issue Apr 7, 2020 · 11 comments

Comments

@phmarek
Copy link

phmarek commented Apr 7, 2020

Please use the version from https://github.com/jdz/cl-base64 which has quite a few fixes.

The old one from kpe goes OOM when running (base64:base64-string-to-string nil), for example.

@quicklisp
Copy link
Owner

Have you contacted Kevin about incorporating bug fixes?

@phmarek
Copy link
Author

phmarek commented Apr 8, 2020

Yes, I sent an email yesterday...
But as the latest contribution on http://git.kpe.io/ is 2 years ago I went and found the newer jdz repo - that looks actively maintained.

@quicklisp
Copy link
Owner

I'm not going to switch without some discussion with the original author. Please allow some time for him to respond. If there is no timely response, we can revisit. If you want something sooner, fork it with a new name.

@phmarek
Copy link
Author

phmarek commented Apr 8, 2020

No problem. It's 3 weeks until the next QL release anyway ;)

"fork it" as in "fork QL" or "fork CL-BASE64"? The jdz repo has all the commits of the original one, plus a few more commits - the important one might be the one removing (safety 0) - so forking with a new name doesn't make sense to me...

@quicklisp
Copy link
Owner

"Fork CL-BASE64" as in, make a project with the desired fixes with a new name.

It's better to work with the original author before/instead of doing that, though.

@phoe
Copy link

phoe commented Apr 8, 2020

(Absolute nitpick: I don't think we need a fifth base64 library in Quicklisp.)

@Hexstream
Copy link
Contributor

We would do well to fix our perennial Discoverability Problem and consolidate a bit, yes.

@jdz
Copy link

jdz commented Apr 9, 2020

For the record I've sent a mail to Kevin (at rosenberg.net) on July 8,
2019.

I personally would like if my changes were merged into the original
project. But I also don't have the energy to chase the author around.
I'm grateful for the effort people have put into creating a library,
and I also can understand that their life priorities may have changed.

It would be nice if anybody could get a response from Kevin about his
ability to do CL library maintenance. Maybe it would be beneficial
for the community if the projects were moved to sharplispers?

@phoe
Copy link

phoe commented Apr 28, 2020

If no one did not get a response from Kevin, I vote for moving the project over to @sharplispers and maintaining it there.

@phmarek
Copy link
Author

phmarek commented Apr 28, 2020

Well, IMO is as good a maintainer as we'll ever get, so why not just switch over?
Of course, asking him to donate that repo to the sharplispers might be a good idea as well...

@kevinrosenberg
Copy link

Hi Jānis, thanks for the improvements on this package. Phil Marek just let me know about your repository and I'm very happy to merge your improvements.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants