Properly overwrite previous spinner lines on dynamic TTY #164
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ut artifacts if the template changes
Codecov Report
@@ Coverage Diff @@
## master #164 +/- ##
==========================================
- Coverage 80.16% 79.94% -0.22%
==========================================
Files 30 30
Lines 1467 1471 +4
==========================================
Hits 1176 1176
- Misses 291 295 +4
Continue to review full report at Codecov.
|
|
Thanks much! I could not push to this branch, so I merged it manually. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #162.
This will add padding after the spinner output to make sure that any remaining output has been properly overwritten. Previous implementation could leave garbage if template length changes dynamically.