Skip to content

Properly overwrite previous spinner lines on dynamic TTY #164

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Properly overwrite previous spinner lines on dynamic TTY #164

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 13 additions & 3 deletions R/spinner.R
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -128,7 +128,7 @@ make_spinner <- function(which = NULL, stream = stderr(), template = "{spin}",
c_state <- 1L
c_first <- TRUE
c_col <- 1L
c_width <- console_width()
c_width <- 0L
c_last <- Sys.time() - as.difftime(1, units = "secs")
c_int <- as.difftime(c_spinner$interval / 1000, units = "secs")

Expand Down Expand Up @@ -162,7 +162,17 @@ make_spinner <- function(which = NULL, stream = stderr(), template = "{spin}",
if (throttle()) return()
line <- sub("{spin}", c_spinner$frames[[c_state]], c_template,
fixed = TRUE)
cat("\r", line, sep = "", file = stream)
line_width <- nchar(line)
# extra padding in case the line width has changed
# so that we don't get any garbage in the output
padding <- if (line_width < c_width) {
paste0(rep(" ", line_width), collapse = "")
} else {
""
}
cat("\r", line, padding, sep = "", file = stream)
# save the new line width
c_width <<- line_width
inc()
}

Expand All @@ -174,7 +184,7 @@ make_spinner <- function(which = NULL, stream = stderr(), template = "{spin}",
if (throttle()) return()
cat(".", file = c_stream)
c_col <<- c_col + 1L
if (c_col == c_width) {
if (c_col == console_width()) {
cat("\n", file = c_stream)
c_col <<- 1L
}
Expand Down