Skip to content

Conversation

IndrajeetPatil
Copy link
Collaborator

via spelling::update_wordlist()

via `spelling::update_wordlist()`
Copy link
Contributor

This is how benchmark results would change (along with a 95% confidence interval in relative change) if 4f78252 is merged into main:

  • ✔️cache_applying: 147ms -> 149ms [-1.05%, +3.68%]
  • ✔️cache_recording: 508ms -> 509ms [-0.76%, +1.08%]
  • ✔️without_cache: 969ms -> 971ms [-0.5%, +0.91%]

Further explanation regarding interpretation and methodology can be found in the documentation.

@lorenzwalthert
Copy link
Collaborator

I did not know about spelling::update_wordlist(). Maybe the pre-commit hook should use it instead of a custom logic that only adds words and never removes words when the --read-only flag is absent. Interested in a PR there? 😀

Copy link
Collaborator

@lorenzwalthert lorenzwalthert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks.

@IndrajeetPatil IndrajeetPatil merged commit d07e4d3 into main May 23, 2024
@IndrajeetPatil
Copy link
Collaborator Author

Yes, I can update precommit to use spelling package in a separate PR.

@IndrajeetPatil IndrajeetPatil deleted the rm-nonexistent-vignette-refs branch May 23, 2024 20:54
@IndrajeetPatil
Copy link
Collaborator Author

I did not know about spelling::update_wordlist(). Maybe the pre-commit hook should use it instead of a custom logic that only adds words and never removes words when the --read-only flag is absent. Interested in a PR there? 😀

I created an issue upstream so that everyone can benefit from these changes, and not just {styler}:

lorenzwalthert/precommit#572

Either I or someone else can work on it if you can't.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants