Check additional applications when comparing bazel and make results #8209
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HoloRin
force-pushed
the
rin/check-more-apps-in-bazel-make-comparison-workflow
branch
2 times, most recently
from
73a7906 to
186f746
Compare
HoloRin
force-pushed
the
rin/check-more-apps-in-bazel-make-comparison-workflow
branch
from
940cc52 to
c5ea908
Compare
HoloRin
force-pushed
the
rin/check-more-apps-in-bazel-make-comparison-workflow
branch
3 times, most recently
from
7cd1cfb to
0e57c1a
Compare
HoloRin
force-pushed
the
rin/check-more-apps-in-bazel-make-comparison-workflow
branch
2 times, most recently
from
4c31cd6 to
47bd970
Compare
It's listed as a required key in https://www.erlang.org/doc/man/app.html, but the same docs state the default is "[]". It seems to ignore it if it's empty.
Normally it would be generated with `bazel run gazelle-update-repos -- -args osiris@1.5.1=github.com/rabbitmq/osiris@v1.5.1`, but in this case we just want to match it's compilation with erlang.mk with some manual tweaks.
HoloRin
force-pushed
the
rin/check-more-apps-in-bazel-make-comparison-workflow
branch
from
1353f43 to
8f66031
Compare
HoloRin
deleted the
rin/check-more-apps-in-bazel-make-comparison-workflow
branch
|
@Mergifyio backport v3.12.x v3.11.x |
✅ Backports have been created
|
mergify bot
pushed a commit
that referenced
this pull request
Aug 13, 2023
…8209) * Check additional applications when comparing bazel and make results * Sync bazel/make for amqp_client * Do not fail-fast in build system comparison * promethus -> prometheus * Regenerate BUILD.redbug * When comparing build systems & .app files ignore empty 'registered' It's listed as a required key in https://www.erlang.org/doc/man/app.html, but the same docs state the default is "[]". It seems to ignore it if it's empty. * Copy bazel/BUILD.osiris from BUILD.bazel in the osiris repo Normally it would be generated with `bazel run gazelle-update-repos -- -args osiris@1.5.1=github.com/rabbitmq/osiris@v1.5.1`, but in this case we just want to match it's compilation with erlang.mk with some manual tweaks. * Use elixir 1.15, otherwise mix format fails * Sync bazel/make for rabbitmq_web_dispatch, rabbitmq_management_agent (cherry picked from commit ca1806d) # Conflicts: # .github/workflows/check-build-system-equivalence.yaml
mergify bot
pushed a commit
that referenced
this pull request
Aug 13, 2023
…8209) * Check additional applications when comparing bazel and make results * Sync bazel/make for amqp_client * Do not fail-fast in build system comparison * promethus -> prometheus * Regenerate BUILD.redbug * When comparing build systems & .app files ignore empty 'registered' It's listed as a required key in https://www.erlang.org/doc/man/app.html, but the same docs state the default is "[]". It seems to ignore it if it's empty. * Copy bazel/BUILD.osiris from BUILD.bazel in the osiris repo Normally it would be generated with `bazel run gazelle-update-repos -- -args osiris@1.5.1=github.com/rabbitmq/osiris@v1.5.1`, but in this case we just want to match it's compilation with erlang.mk with some manual tweaks. * Use elixir 1.15, otherwise mix format fails * Sync bazel/make for rabbitmq_web_dispatch, rabbitmq_management_agent (cherry picked from commit ca1806d) # Conflicts: # .github/workflows/check-build-system-equivalence.yaml # MODULE.bazel
This was referenced Aug 13, 2023
Merged
michaelklishin
added a commit
that referenced
this pull request
Aug 13, 2023
Check additional applications when comparing bazel and make results (backport #8209)
michaelklishin
added a commit
that referenced
this pull request
Aug 13, 2023
Check additional applications when comparing bazel and make results (backport #8209)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will confirm that deps like ra and osiris are also equivalent