Setting type of computed attribute for schema breaks output #356
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
eeb123d contains a test that fails against master; the other commits contain a proposed fix and doc updates.
It seems that the changes for schema output overloaded the behaviour for setting an alternate attribute key that was already there, as changing the code so that it matched the behaviour described in the README broke other tests.
Here's the local output from the failing test, note the :string => nil.
I couldn't think of any way around this that didn't involve changing the
attributes
calling conventions, so I chose to preserve what was already in the code and add type as a separate property. The fix I've adopted may not be quite what's needed, but hopefully it gets part of the way there...