Skip to content

Conversation

callumj
Copy link

@callumj callumj commented Aug 7, 2013

This pull request breaks up the mapping of serializer class instantiation to serializable_hash / as_json. One method maps the serializer instances and the original serializable_array emits them as serializable hashes.

This is for those that wish to extend ActiveModel::ArraySerializer but only want to modify specific behaviour such as serializable_array but wish to take advantage of the helpful serializer instantiation.

@coveralls
Copy link

Coverage Status

Coverage increased (+0%) when pulling 2966fe3 on callumj:master into 8ac4bf9 on rails-api:master.

@spastorino
Copy link
Contributor

This is already fixed in master after the rewrite. Thanks for doing the work anyway.

@spastorino spastorino closed this Oct 22, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants