Use the DefaultSerializer for embedded objects when no serializer is specified #390
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using
embed :ids, include: true
, and the model class being embedded doesnot implement
active_model_serializer
, then a default serialization shouldhappen.
The else branch in
ActiveModel::Serializer::Association#find_serializable
didnot yet have a test case, and would cause the following error :
This is because
merge_association
callsfind_serializable
, and expects anobject that responds to
#object
and#serializable_hash
, which is not thecase for the model instance itself. This commit wraps the object in a
DefaultSerializer so it satisfies the interface the caller expects.