Add optional recursive camelization of keys.

[mhenrixon]

This is still sort of a hack. I don't like what I have to do to be able to camelize the root key, I believe a simple setting to switch on would have been nicer but hey it works.

Any suggestions for improvements deeply appreciated.

[coveralls]

Coverage increased (+0.03%) when pulling d0e0e1b on mhenrixon:convert_keys into ebe3afe on rails-api:master.

[coveralls]

Coverage increased (+0.03%) when pulling 3c362b4 on mhenrixon:convert_keys into ebe3afe on rails-api:master.

[spastorino]

Is this needed? ^^^

[mhenrixon]

not really, I can do def self.included if you want?

[spastorino]

You should just include Convertable, there's no need to use that hook

[spastorino]

All the things changed in the README file does not belong to this commit.
And were all already pushed in a previous PR.

[spastorino]

Last thing is that I'd execute the convertion of the keys right after the execution of attributes, has_one and has_many so we don't pay the penalty of converting these things on each request.

[spastorino]

We are discussing about how to treat keys but meanwhile we don't reach a conclusion I wouldn't convert the key back to symbol.
Just leave it as is.

[mhenrixon]

I don't like the string key return at all, that's my personal opinion and for what it is worth you can take that into consideration when discussing it :) I'll change it for now though I would hate to see AMS get all stringy on me. What would the benefit of that be?

[spastorino]

Thanks a lot for your work.

[mhenrixon]

Last thing is that I'd execute the convertion of the keys right after the execution of attributes, has_one and has_many so we don't pay the penalty of converting these things on each request.

The problem is it needs to be done for roots as well. Right now we have some logic in serializable.rb and some in serializer.rb. I still want to convert the root element key right?

[mhenrixon]

Regarding when to convert keys:

def attributes(*attrs)
  @_attributes.concat attrs
  attrs.each do |attr|
    define_method attr do
      object.read_attribute_for_serialization attr
    end unless method_defined?(attr)
  end
end

Won't that I have to keep track of both the converted key and the original key? Is the penalty really worth it?

[coveralls]

Coverage decreased (-0.29%) when pulling 7f32e16 on mhenrixon:convert_keys into ebe3afe on rails-api:master.

[coveralls]

Coverage decreased (-0.3%) when pulling 8583cb2 on mhenrixon:convert_keys into 49ab359 on rails-api:master.

[mhenrixon]

Closing in favor of #436 since that seems like a better solution to me.