Using a HasOne association twice raises an exception (Undefined method `map') #452
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…w causes an exception.
|
I ran into this issue and this PR fixes the issue for me. |
|
I realize my explanation it not very clear, but the code is quite straightforward. Should I supply more info? Feeback would be appreciated! |
This was referenced Dec 8, 2013
Closed
|
Closes #456 |
spastorino
added a commit
that referenced
this pull request
Dec 17, 2013
Using a HasOne association twice raises an exception (Undefined method `map')
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When an
Associationdetects that it is serializing an array, it callsuse_array_serializer!to set the serializer toArraySerializer, and set@options[:each_serializer]to the current serializer.When
use_array_serializer!is called a second time,:each_serializeris nowArraySerializerwhich causes things to blow up.The symptom is "Undefined method `map'", since the ArraySerializer tries to iterate over a single object.
The
HasManyassociation already contained a check to prevent callinguse_array_serializer!twice, this PR adds a similar check toHasOne.