Skip to content

Correctly retrieve the SQL Server database version #1361

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

Correctly retrieve the SQL Server database version #1361

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
23dd9a5
correctly retrieve the SQL Server database version
bvogelzang Oct 1, 2025
de7b025
Merge branch '7-1-stable' into pr/1361
aidanharan Oct 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,8 @@
## v7.1.11
## Unreleased

#### Fixed

Correctly retrieve the SQL Server database version.

#### Fixed

Expand Down
2 changes: 1 addition & 1 deletion lib/active_record/connection_adapters/sqlserver_adapter.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -505,7 +505,7 @@ def version_year
end

def sqlserver_version
@sqlserver_version ||= _raw_select("SELECT @@version", @raw_connection).first.first.to_s
@sqlserver_version ||= execute("SELECT @@version", "SCHEMA").rows.first.first.to_s
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AFAIK execute("SELECT @@version", "SCHEMA") will just return the number of rows affected as an integer. It won't return rows of data. I think the fix for 7.1 will be different than what is in main.

end

private
Expand Down
10 changes: 10 additions & 0 deletions test/cases/adapter_test_sqlserver.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -129,6 +129,16 @@ class AdapterTestSQLServer < ActiveRecord::TestCase
end
end

it 'test proper connection before fetching sqlserver_version'
connection.disconnect!

assert_nothing_raised do
version = connection.sqlserver_version
assert version.is_a?(String)
assert version.length > 0
end
end

describe "with different language" do
before do
@default_language = connection.user_options_language
Expand Down
Loading