Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added support for MSSQL2016 #514

Closed
wants to merge 1 commit into from
Closed

added support for MSSQL2016 #514

wants to merge 1 commit into from

Conversation

udaykadaboina
Copy link

Added Support for MSSQL2016

@udaykadaboina
Copy link
Author

@metaskills can you take a look and let me know if I need to do anything more?

@metaskills
Copy link
Contributor

Thanks. What branch are you making this pull request too? We dropped that version stuff in 4-2-stable and forward so this could only be relevant for 4-1-stable and below.

@udaykadaboina
Copy link
Author

udaykadaboina commented Oct 6, 2016

@metaskills Ideally I'm looking for 3-2-stable. Thanks!

@metaskills
Copy link
Contributor

Perfect, I see now too!

screen shot 2016-10-06 at 7 47 33 am

@udaykadaboina
Copy link
Author

@metaskills Strangely for some reason this branch is missing a method:

      def sqlserver_2014?
        @database_year == 2014
      end

If you would like, I can add this too and then it will be ready to package into a new gem version? Let me know!

@metaskills
Copy link
Contributor

I can do that, because when I add this, I will have to cut a new branch for 3.2, 4.0, and 4.1

@udaykadaboina
Copy link
Author

@metaskills Awesome! 👍 will keep an eye for the new version of gem.

@udaykadaboina
Copy link
Author

@metaskills @annaswims Hi! Is there an eta of when new version will be released?

Thanks!

@metaskills
Copy link
Contributor

No, but I am making good progress for Hacktoberfest this month on it :)

@metaskills
Copy link
Contributor

Thanks, but I just went ahead and pushed updates to 3-2-stable up to 4-1-stable that allows vNext. New gems pushed to rubygems.org too. Cheers!!!

@metaskills metaskills closed this Jan 24, 2017
@udaykadaboina udaykadaboina deleted the support-mssql2016 branch March 14, 2017 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants