Skip to content

Conversation

yourivdlans
Copy link

This pull fixes an issue with having data-remote=true on a radio or checkbox input. Because the browser will not send a value for an unchecked input this PR adds the empty value. Just like the regular Rails form would.

fixes #440

@rails-bot
Copy link

Thanks for the pull request, and welcome! The Rails team is excited to review your changes, and you should hear from @lucasmazza (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improved data-remote for checkboxes?
3 participants