fix bzip2 magic detection #131
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi folks, 👋
this patch is actually a fix from @tomhughes.
See also the fix in OSM and Tom also opened issue #128 for that.
I added a minimal bzip file (
echo -n '' | bzip2 > test/fixtures/magic/application/x-bzip2/bzip2.bz2
) to the fixtures and the fix works just as expected.PS: I'm looking for a new adventure in case anybody is looking for a Ruby/Rails/Crystal dev
PPS: would you be so kind and add the
hacktoberfest-accepted
label to this issue in case you find that PR helpful? 🥺