add tika.xml regex support
#132
Open
+413
−27
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexanderadam
force-pushed
the
fix/bzip2_detection_with_regex_issue_128
branch
from
61d8d7d to
be31098
Compare
alexanderadam
force-pushed
the
fix/bzip2_detection_with_regex_issue_128
branch
2 times, most recently
from
51a18d3 to
48ae619
Compare
alexanderadam
force-pushed
the
fix/bzip2_detection_with_regex_issue_128
branch
from
48ae619 to
e0fde31
Compare
alexanderadam
changed the title
tika.xml regex supporttika.xml regex support
alexanderadam
force-pushed
the
fix/bzip2_detection_with_regex_issue_128
branch
2 times, most recently
from
31b0420 to
73165bd
Compare
This will work for simple things only because we're using a different regex engine. But out of all the current regular expressions, only the one for `application/x-dbf` fails. So I guess we're good. And we can get rid of that html definition now.
alexanderadam
force-pushed
the
fix/bzip2_detection_with_regex_issue_128
branch
from
73165bd to
c70d3d3
Compare
alexanderadam
changed the title
tika.xml regex supporttika.xml regex support
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will work for "simple" things only because we're using a different regex engine.
But out of the 36 regular expressions, only the one for
application/x-dbffails.So I guess we're good?
I didn't even expect it to work this reliably tbh. 😉
And we can get rid of that html definition in
lib/marcel/mime_type/definitions.rbnow. 🎉Furthermore I hoped that this would also make #130 obsolete, because
looked pretty decent at first but a JS string with
html='<html><h1>';will still trick it, right? 🤔While I'm generally happy with how it turned out, I would really love it if somebody has a better idea than switching
$VERBOSEoff and on again.Or we leave it and just accept the warnings?
I couldn't find anything nice to solve this better yet.
Anyway, this was a lot of fun to implement but I really should go to bed now. 😆
EDIT: So this is actually more complicated. I had failing runs on TruffleRuby and JRuby
EDIT2: okay, it looks like everything is running now on all the platforms. What a ride! 😆
/CC @tomhughes
PS: I'm looking for a new adventure in case anybody is looking for a Ruby/Rails/Crystal dev
PPS: would you be so kind and add the
hacktoberfest-acceptedlabel to this issue in case you find that PR helpful? 🥺