This repository was archived by the owner on Sep 13, 2017. It is now read-only.
Remove required field polyfill #16
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This polyfill prevents the submission of forms (both `remote` and standard) if there are blank required inputs. This behavior is implemented natively by most modern browsers, the sole holdout being Safari. When the behavior is handled natively by the browser, the user is shown appropriate error messages. When the behavior falls through the Polyfill, there is no notification to the user as to why their form now fails to submit. To the user, the form simply appears broken. The source of this behavior is difficult for developers to track down. jquery-ujs has a [longstanding issue][1]on this polyfill. With the move to a new gem for ujs in Rails 5.1 we can make this breaking change and remove the incomplete polyfill. [1]:rails/jquery-ujs#319
|
Closes #13 |
|
Thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This polyfill prevents the submission of forms (both
remoteandstandard) if there are blank required inputs. This behavior is
implemented natively by most modern browsers, the sole holdout being
Safari.
When the behavior is handled natively by the browser, the user is shown
appropriate error messages. When the behavior falls through the
polyfill, there is no notification to the user as to why the form now
fails to submit. To the user, the form simply appears broken. The source
of this behavior is difficult for developers to track down.
jquery-ujs has a longstanding issue on this polyfill. With the move
to a new gem for ujs in Rails 5.1 we can make this breaking change and
remove the incomplete polyfill.