Scope without lambda ignores condition chain

[mlitwiniuk]

Consider following models

class Customers < ActiveRecord::Base
  has many :orders
end
class Order < ActiveRecord::Base
  scope :ordered, order('created_at DESC')
  belongs_to :customer
end

Calling following

customer.orders.ordered.to_sql

will result in following sql code:

SELECT "orders".* FROM "orders"   ORDER BY created_at DESC

I consider this important issue, as it's quite easy just to forget using lambda syntax and results are far from expected. Lambda syntax is quite big change in Rails4 and I suspect, that many people will forget about using it. In my opinion exception should be raised in such situations.

This is somehow connected to not yet merged #10528 and issue #10421 - so this ticket just aims to show how serious situation is.

Due to not merged #10528, it's still an issue on branch 4-0-stable.

[mlitwiniuk]

Our, temporary, solution can be found here: galdomedia/activerecord-deprecated_finders@dabc9bc

[senny]

/cc @jonleighton

[jeremyrichardson88]

Not sure if this is by design but while upgrading to rails 4 I was adding the lambda or -> (i thought the same) to the scopes but I get this error when using this syntax:

scope :example, -> { |*args| where('attr = ?', (args.first)) }
error: syntax error, unexpected '|' and the ^ points to the * but no error with this...

scope :example, lambda { |*args| where('attr = ?', (args.first)) }

not sure why this happens exactly

[robin850]

@jeremyrichardson88 : This is Ruby's design. This is more or less the same thing but the syntax is not exactly the same:

-> *args { ... }
# Or
lambda {|*args| ... }

[rafaelfranca]

This issue has been automatically marked as stale because it has not been commented on for at least
three months.

The resources of the Rails team are limited, and so we are asking for your help.

If you can still reproduce this error on the 4-1-stable, 4-0-stable branches or on master,
please reply with all of the information you have about it in order to keep the issue open.

Thank you for all your contributions.

[rafaelfranca]

This is the downside of using scopes without lambda. With Rails 4.1 this is not possible anymore. On Rails 4.0 we already show the deprecation warning and it can be changed to raise an exception if you configure the deprecation behavior to :raise. That said I'm closing this issue