url helpers missing in Resque jobs

[shipstar]

I'm not sure if this is a Rails issue or a Resque issue, so feel free to make me move it.

I recently upgraded from 3.2.12 to 3.2.13. I started seeing the following error message in certain Resque jobs:

In order to use #url_for, you must include routing helpers explicitly. For instance, `include Rails.application.routes.url_helpers

My Resque job is calling out to UserMailer. If I add

class UserMailer < ActionMailer::Base
  include Rails.application.routes.url_helpers

  def invitation_email
    # same error as before
    @invitation_url = invitation_url(@user.invitation_code)
  end
end

I'm still getting the same error message. The only way I can resolve it is by explicitly writing out the entire chain:

@invitation_url = Rails.application.routes.url_helpers.invitation_url(@user.invitation_code)

If I revert back to 3.2.12, the issue goes away.

I've updated to 3.2.14, and tried bumping resque versions as well.

[shipstar]

It seems like this might be a resque issue -- calling #perform on the job directly works as expected. Curiously, it doesn't complain about url_for needing to be included.

It seems like something goes wrong with the url helpers when Resque forks a new process.

[steveklabnik]

I can't think of anything in Resque that would affect this, and since it happens when you change Rails versions, I feel it might be Rails....

[shipstar]

It seems like it's definitely Rails that's causing it. The question is whether it's a regression or something that Resque will need to account for in the future.

[pixeltrix]

@shipstar can you try before and after 6ab1a95 - I wonder whether this might be the cause.

[shipstar]

@pixeltrix That commit does seem to be the offender. 6ab1a95~1 works as expected.

[tinylox]

Any traction on this ? I have encountered it too

[pixeltrix]

@tinylox is this in development or production? Also is it consistent or intermittent?

I know what's raising the error (it's the default implementation of _routes in Abstract Controller) however I can't reproduce this so I'm not sure why it's being called.

[senny]

@shipstar what is the status of this report? Can you publish a way to reproduce?

[shipstar]

I tested it against Rails 4.0.1.rc2 a few weeks back and was still experiencing it. I'll publish something to GitHub this week (hopefully tonight).

[shipstar]

I can't seem to reproduce this in a greenfield Rails project with 4.0.0 or 4.0.1. Must just be a particular configuration of gems that were in play.

I uploaded my code to https://github.com/shipstar/helper_bug in case someone else has better luck reproducing it. I tried adding resque-scheduler (which we were using in the original project), but still couldn't trigger the bug.

Since there's a simple workaround and no reproduction, I'm happy to close this for now.

[senny]

@shipstar thank you for your investigation.

I'm closing this one. If anyone else experiences the issue and is able to make a greenfield reproduction let me know and we can reopen.

[yoniamir]

Hi, i'm experiencing the same exact issue.
I'm running Rails 4.1.13 and resque-1.25.2 .
Is there any new version of resque or Rails that resolves this?