Eager loading has_many association when primary_key is a method #1696
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jake3030
pushed a commit
to jake3030/rails
that referenced
this pull request
Jun 28, 2011
…d associations are empty [rails#1696 state:resolved] Signed-off-by: Pratik Naik <pratiknaik@gmail.com>
|
is this an issue in 3-1-stable? |
|
@piglop Is this still an issue? |
|
This pull request is for a not supported Rails version. I'm closing it now. Please see if this one is still can be applied in the Rails >= 3.1. If so, please open another one against the master branch. Thanks for your contribution. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In a has_many association, the primary key may be a method (the doc says: "Specify the method that returns the primary key used for the association. By default this is id."). It works fine except when the association is eager loaded. In this case it uses the nonexistent attribute and loads an empty list of records.
This fix is based on 3-0-stable.