Using stylesheet_link_tag in a mailer layout currently blows up with "undefined method `params' for #<YourMailer:0x00000105ae87f0>"

[Empact]

And a backtrace like so:

bundler/gems/rails-07ea84a03b2a/actionpack/lib/action_view/helpers/controller_helper.rb:10:in `params'
bundler/gems/rails-07ea84a03b2a/actionpack/lib/sprockets/helpers/rails_helper.rb:78:in `debug_assets?'
bundler/gems/rails-07ea84a03b2a/actionpack/lib/sprockets/helpers/rails_helper.rb:49:in `stylesheet_link_tag'

[Empact]

This is on 3-1-stable btw.

[dmitriy-kiriyenko]

How do you expect stylesheets to work in emails?

[Empact]

Well, I suppose either the link tag should be output or rails should explicitly indicate that it doesn't support such a thing in mailers. As it is it seems like an oversight.

Inlining the css could be handy too, perhaps. I'm don't have so much experience with creating html emails, so I can't say for sure.

[dmathieu]

I think it might be a good idea to deprecate the use of stylesheet_link_tag in emails.
No client supports them anyway as it can be a security issue.

So what we could do would be :

• Fix the stylesheet_link_tag so that it displays the tag.
• Display a warning when that tag is used, inviting people to embed their CSS inline.

Do you want to start working on it ?

[Empact]

Sure I could handle this - but would love to get another comment or two from those more experienced than I on the matter. I probably should check rails 3 to see what the previous behavior was as well.

[TomTriple]

If someone wants to send html email (css inlined or not) he will definately do so with or without support for "stylesheet_link_tag". Due to consistency reasons I think we should support this method for mailer views, too! I don´t see it as a responsibility of a server side framework to display warning messages when using the style tag in html emails. Now you have the problem of two orthogonal opinions for this, too... ;)

[TomTriple]

What´s your opinion on this issue @Empact?

[Empact]

FYI: planning to get to this on during the hackfest (at heroku: http://plancast.com/p/6f8q) this weekend.

[TomTriple]

had this issue in the back of my mind, too. good luck fixing it!

[josh]

Dup #2177