Assets precompiled twice?

[Bodacious]

When I check the log output for rake assets:precomile it looks as though everything is being precompiled twice.

Anyone else getting the same?

If so, I'll investigate

Compiled ~/Sites/MySite/app/assets/javascripts/shared/jquery.livequery.js  (0ms)  (pid 21678)
Compiled ~/Sites/MySite/app/assets/javascripts/shared/jquery.livequery.js  (0ms)  (pid 21678)
Compiled ~/.rvm/gems/ruby-1.9.2-p180-patched@MySite/gems/jquery-rails-1.0.11/vendor/assets/javascripts/jquery-ui.min.js  (0ms)  (pid 21678)
Compiled ~/.rvm/gems/ruby-1.9.2-p180-patched@MySite/gems/jquery-rails-1.0.11/vendor/assets/javascripts/jquery-ui.min.js  (0ms)  (pid 21678)
Compiled ~/.rvm/gems/ruby-1.9.2-p180-patched@MySite/gems/jquery-rails-1.0.11/vendor/assets/javascripts/jquery.min.js  (0ms)  (pid 21678)
Compiled ~/.rvm/gems/ruby-1.9.2-p180-patched@MySite/gems/jquery-rails-1.0.11/vendor/assets/javascripts/jquery.min.js  (0ms)  (pid 21678)

[Bodacious]

In dev, staging and production modes

[spastorino]

Have you tried with 3-1-stable and sprockets from master?

[josh]

I bet this is fixed by sprockets/master now.

[Bodacious]

Um...

Am I doing something wrong here?

http://www.screencast.com/users/gavin_morrice/folders/Jing/media/a4b7e1a6-68f2-464a-8606-98f438004b32

Doesn't seem to be precompiling at all now - tried with assets.config.precompile += %w{ application } too - no luck

[Bodacious]

Ignore that! Forgot to use Rails 3-1-stable

I'm still seeing the same with sprockets master and 3-1-stable

Compiled ~/Sites/test_sprockets/app/assets/javascripts/application.js  (3ms)  (pid 38095)
Compiled ~/Sites/test_sprockets/app/assets/javascripts/application.js  (0ms)  (pid 38095)
Compiled ~/Sites/test_sprockets/app/assets/stylesheets/application.css  (1ms)  (pid 38095)
Compiled ~/Sites/test_sprockets/app/assets/stylesheets/application.css  (0ms)  (pid 38095)

Looking at the time though, it looks as though it's being logged twice but not actually compiling twice.

thoughts?

[tenderlove]

I've been able to confirm this. Looking in to it.

[tenderlove]

I have been looking in to this, but I just get lost in the sprockets code. @josh can you please take a look?

Here is a video that reproduces the issue with Rails 3.1.0.rc4 and Sprockets Beta 10.

Here is another video that reproduces the problem with Rails 3-1-stable branch and Sprockets master.

Unsure if it's an important detail, but this seems to compile application.js and application.css twice.

[josh]

@tenderlove love your videos ⭐

I think this might be harmless. Guess its getting a cache hit the second time, but its still bothering me.

[gnufied]

okay, I did some work on this and looks like, it is not that asset is getting compiled twice, but evaluate is getting called twice, once in BundledAsset constructor and once in BundledAsset#source method, but when second time it is getting called, the body is already set.

Does not look like a bug, IMO per se, but there does not seem to be a obvious fix.

@cc josh

[josh]

@gnufied good catch. I think the fix is to move that log call somewhere else. Part of the issue is that body and source are lazily generated. So theres not one good place to wrap the log statement.

Opening a ticket on sprockets for this.

sstephenson/sprockets#132