Fix after_initialize and Base.create edge case #2236
Conversation
fix behavior when after_initialize is defined and a block is passed to Base.create
| @@ -0,0 +1,9 @@ | |||
| class WholesaleProduct < ActiveRecord::Base | |||
There was a problem hiding this comment.
Actually the ActiveRecord maintainers would prefer that you use existing models for new tests instead of add new models
There was a problem hiding this comment.
I poked around existing models to see if there was one I could use for this test, but I didn't see one that I could easily repurpose. I didn't want to mess with one that looked they were being used for specific test cases, which most of the ones I looked at seemed to be. I could have put it at the top of the test file, but none of the other classes up there had method declarations. It's my first submitted patch, so I just tried to not mess with things that were already in place too much.
|
@guilleiguaran Updated tests to use existing model. Personally, I don't see it as a good testing practice to be using one model for multiple unrelated tests. Leads to unnecessary coupling and hard to find bugs |
|
I agree with you but we must try to avoid defining extra models since we already have tonnes of them and if every patch add a new model it would quickly get out of hand. Your code and tests looks great, thanks!!! |
Fix after_initialize and Base.create edge case
This time rebased off master as requested in #2194