Update grammar for config.enable_dependency_loading docs
#25476
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -94,7 +94,7 @@ application. Accepts a valid week day symbol (e.g. `:monday`). | |||
|
|
|||
| * `config.eager_load_paths` accepts an array of paths from which Rails will eager load on boot if cache classes is enabled. Defaults to every folder in the `app` directory of the application. | |||
|
|
|||
| * `config.enable_dependency_loading` when true, enable the autoload loading behavior even if the application is eager loaded and have `cache_classes` as true. Default to false. | |||
| * `config.enable_dependency_loading` enables autoload loading, even if the application is eager loaded and `config.cache_classes` is set as true. Defaults to false. | |||
There was a problem hiding this comment.
We should maintain the "when true" to indicate when this behaviour occurs
maclover7
force-pushed
the
jm-docs-dep-loading
branch
from
85dec85 to
b9f338c
Compare
|
updated @vipulnsward, okay to 🚢? |
| @@ -94,7 +94,7 @@ application. Accepts a valid week day symbol (e.g. `:monday`). | |||
|
|
|||
| * `config.eager_load_paths` accepts an array of paths from which Rails will eager load on boot if cache classes is enabled. Defaults to every folder in the `app` directory of the application. | |||
|
|
|||
| * `config.enable_dependency_loading` when true, enable the autoload loading behavior even if the application is eager loaded and have `cache_classes` as true. Default to false. | |||
| * `config.enable_dependency_loading` -- when true, enables autoload loading, even if the application is eager loaded and `config.cache_classes` is set as true. Defaults to false. | |||
There was a problem hiding this comment.
Is the -- used elsewhere in the file? If not, I'd remove them for consistency.
There was a problem hiding this comment.
Varies a little bit by each section of this guide, the initializer section uses : instead of a double dash, I can change to that, if you'd like :)
There was a problem hiding this comment.
If this is the only instance of --, I'd go with one of the other options :)
maclover7
force-pushed
the
jm-docs-dep-loading
branch
from
b9f338c to
d5fea4f
Compare
|
updated @kaspth :) |
|
🚢 |
|
👍 thanks for the review, all! <3 |
|
No problem ❤️ Should this be backported? |
|
👍 good idea, since the original commit is in |
This was referenced Jun 24, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[ci skip]
r? @rafaelfranca