-
Notifications
You must be signed in to change notification settings - Fork 21.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update grammar for config.enable_dependency_loading
docs
#25476
Conversation
@@ -94,7 +94,7 @@ application. Accepts a valid week day symbol (e.g. `:monday`). | |||
|
|||
* `config.eager_load_paths` accepts an array of paths from which Rails will eager load on boot if cache classes is enabled. Defaults to every folder in the `app` directory of the application. | |||
|
|||
* `config.enable_dependency_loading` when true, enable the autoload loading behavior even if the application is eager loaded and have `cache_classes` as true. Default to false. | |||
* `config.enable_dependency_loading` enables autoload loading, even if the application is eager loaded and `config.cache_classes` is set as true. Defaults to false. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should maintain the "when true" to indicate when this behaviour occurs
85dec85
to
b9f338c
Compare
updated @vipulnsward, okay to 🚢? |
@@ -94,7 +94,7 @@ application. Accepts a valid week day symbol (e.g. `:monday`). | |||
|
|||
* `config.eager_load_paths` accepts an array of paths from which Rails will eager load on boot if cache classes is enabled. Defaults to every folder in the `app` directory of the application. | |||
|
|||
* `config.enable_dependency_loading` when true, enable the autoload loading behavior even if the application is eager loaded and have `cache_classes` as true. Default to false. | |||
* `config.enable_dependency_loading` -- when true, enables autoload loading, even if the application is eager loaded and `config.cache_classes` is set as true. Defaults to false. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is the -- used elsewhere in the file? If not, I'd remove them for consistency.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Varies a little bit by each section of this guide, the initializer section uses :
instead of a double dash, I can change to that, if you'd like :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If this is the only instance of --, I'd go with one of the other options :)
b9f338c
to
d5fea4f
Compare
updated @kaspth :) |
🚢 |
👍 thanks for the review, all! <3 |
No problem ❤️ Should this be backported? |
👍 good idea, since the original commit is in |
[ci skip]
r? @rafaelfranca