`rails plugin new` does not complete properly since bundler 1.12

[jrochkind]

Bundler 1.12 seems to refuse to do any bundle operations if the Gemfile is considered 'invalid' becuase it has TODO in the summary/author/etc, which is how default gemfiles are generated.

This means the final bundle install of the generator script does not work, so you don't actually have a bundled app. I don't think the plugin script contains any post_bundle hooks, so it's not as bad as it could be -- any post_bundle hooks probably won't run at all, or won't work properly. (Third party software providing generators building on plugin new could provide such post_bundle hooks, and be broken worse).

With Bundler 1.13 there's a different(?) worse problem, but I assume if that problem were resolved this one would still be waiting.

$ ruby -v
ruby 2.3.1p112 (2016-04-26 revision 54768) [x86_64-darwin15]
$ rails -v
Rails 5.0.0.1
$ bundle -v
Bundler version 1.12.5

$rails plugin new testplugin
      create
      create  README.md
      create  Rakefile
      create  testplugin.gemspec
      create  MIT-LICENSE
      create  .gitignore
      create  Gemfile
      create  lib/testplugin.rb
      create  lib/tasks/testplugin_tasks.rake
      create  lib/testplugin/version.rb
      create  bin/test
      create  test/test_helper.rb
      create  test/testplugin_test.rb
      append  Rakefile
  vendor_app  test/dummy
         run  bundle install
You have one or more invalid gemspecs that need to be fixed.
The gemspec at /Users/jrochkind/code/testplugin/testplugin.gemspec is not valid. Please fix this gemspec.
The validation error was '"FIXME" or "TODO" is not a description'

With bundler 1.11.2, this does not reproduce, the rails plugin new completes without errors, and the bundle install happens.

[vipulnsward]

We don't bundle install now- fbd1e98

Need to check the Gemfile though.

[jrochkind]

Ah, I see, fbd1e98 is not included in 5.0.0.1 I guess, so by 'now' you mean in 'master', and in a yet to be released future Rails? Okay, I guess that works.

Would encourage a bug fix release sooner rather than later, since this makes rails generators broken with recent Bundler releases.

[jrochkind]

Also, the plugin generator theoretically supports after_bundle callbacks.

If bundle install isn't being run... what is an after_bundle callback, will it never be run, will it be run but without running bundle install first? Either option seems like a bug, and I can't think of any other option. I don't think you can support after_bundle callbacks if you aren't bundling, yes?

I guess the built-in plugin new task has no after_bundle callbacks, but it's still got the hook to run them -- are there supported ways to build your own template on top of plugin, and could some of those be using after_bundle callbacks, and will those break in an environment where there's no bundle install and mysterious behavior of after_bundle callbacks?

[rafaelfranca]

This is fixed in cbb6a26.

And yes, after_bundle will be not supported by plugins.

[jrochkind]

If I understand the code right, at the moment after_bundle is supported... it just doesn't happen after bundling, since no bundling happens since cbb6a26. But the generator is still gonna call any after_bundle callbacks here, isn't it? Should that be removed?

[rafaelfranca]

Yes, it should be removed
On ter, 13 de set de 2016 at 23:20 Jonathan Rochkind <
notifications@github.com> wrote:

If I understand the code right, at the moment after_bundle is
supported... it just doesn't happen after bundling, since no bundling
happens since cbb6a26
cbb6a26.
But the generator is still gonna call any after_bundle callbacks here

rails/railties/lib/rails/generators/rails/plugin/plugin_generator.rb

Lines 263 to 267 in 92703a9

	def run_after_bundle_callbacks
	@after_bundle_callbacks.each do |callback|
	callback.call
	end
	end

,
isn't it? Should that be removed?

—
You are receiving this because you modified the open/close state.

Reply to this email directly, view it on GitHub
#26474 (comment), or mute
the thread
https://github.com/notifications/unsubscribe-auth/AAC66PzKO_f9Gz69fGZO9reMMZtkLa-iks5qp1n8gaJpZM4J679b
.