cookies.delete broken for request type other than GET in controller tests

[iamchucky]

Steps to reproduce

Reproduction Script

Expected behavior

cookies["foo"] in test cases should be nil after cookies.delete is called in controller

Actual behavior

only GET request has the cookies["foo"] deleted while other request types still has cookies["foo"]

System configuration

Rails version: 5.0.1, 5-0-stable
Ruby version: 2.3.1p112

Note that this is passing for Rails 4.2.7.1

I've noticed that ae29142 has cookies.update res.cookies only for get but not for other request types, is that the root of the issue though?

This issue also seems to be related:
rspec/rspec-rails#1574

[maclover7]

👍 Can confirm failing on master, passing on 4-2-stable. Looks like ae29142 / 8363b87 are the commits that touched this part of the codebase.

Working on a solution...

[maclover7]

Opened up #27586 to solve this.

[rafaelfranca]

I had to revert because the fix caused a new regression