New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

ActionCable + Ruby 2.5.0-rc1 Argument Error #31517

Closed
Petercopter opened this Issue Dec 19, 2017 · 4 comments

Comments

Projects
None yet
3 participants
@Petercopter

Petercopter commented Dec 19, 2017

Steps to reproduce

Install Ruby 2.5.0-rc1
Load a page with ActionCable listening

Expected behavior

Log should be free of errors

Actual behavior

wrong number of arguments (given 283856384, expected 0) 馃樃

#<Thread:0x00007fbb44c01b90@/Users/petercopter/.rbenv/versions/2.5.0-rc1/lib/ruby/gems/2.5.0/gems/actioncable-5.1.4/lib/action_cable/connection/stream_event_loop.rb:73 run> terminated with exception (report_on_exception is true):
Traceback (most recent call last):
	5: from /Users/petercopter/.rbenv/versions/2.5.0-rc1/lib/ruby/gems/2.5.0/gems/actioncable-5.1.4/lib/action_cable/connection/stream_event_loop.rb:73:in `block (2 levels) in spawn'
	4: from /Users/petercopter/.rbenv/versions/2.5.0-rc1/lib/ruby/gems/2.5.0/gems/actioncable-5.1.4/lib/action_cable/connection/stream_event_loop.rb:84:in `run'
	3: from /Users/petercopter/.rbenv/versions/2.5.0-rc1/lib/ruby/gems/2.5.0/gems/actioncable-5.1.4/lib/action_cable/connection/stream_event_loop.rb:84:in `loop'
	2: from /Users/petercopter/.rbenv/versions/2.5.0-rc1/lib/ruby/gems/2.5.0/gems/actioncable-5.1.4/lib/action_cable/connection/stream_event_loop.rb:94:in `block in run'
	1: from /Users/petercopter/.rbenv/versions/2.5.0-rc1/lib/ruby/gems/2.5.0/gems/actioncable-5.1.4/lib/action_cable/connection/stream_event_loop.rb:94:in `select'
/Users/petercopter/.rbenv/versions/2.5.0-rc1/lib/ruby/gems/2.5.0/gems/actioncable-5.1.4/lib/action_cable/connection/stream_event_loop.rb:94:in `lock': wrong number of arguments (given 283856384, expected 0) (ArgumentError)
WebSocket error occurred: Broken pipe

System configuration

Rails 5.1.4
Ruby 2.5.0-rc1

@eileencodes

This comment has been minimized.

Show comment
Hide comment
@eileencodes

eileencodes Dec 20, 2017

Member

@Petercopter thanks for the report. Can you provide a new application on Rails 5.1.4 or master with Ruby 2.5.0 that reproduces this error? That will help us track this down. Thanks!

Member

eileencodes commented Dec 20, 2017

@Petercopter thanks for the report. Can you provide a new application on Rails 5.1.4 or master with Ruby 2.5.0 that reproduces this error? That will help us track this down. Thanks!

@Petercopter

This comment has been minimized.

Show comment
Hide comment
@Petercopter

Petercopter Dec 20, 2017

@eileencodes Thanks for looking into this. I've setup a new application here:
https://github.com/Petercopter/ruby_2_5_test

I used the basic ActionCable instructions to get up and running, and it appears to be pretty similar to what I have in production. I confirmed that things were working with 2.4.2 before switching over to 2.5.0, and luckily the error is readily apparent.

If you pull the application, just start server and visits /posts, you will see it. Let me know what else I can do, I'm happy to be helping.

Completed 200 OK in 251ms (Views: 241.2ms | ActiveRecord: 0.4ms)

Started GET "/cable" for 127.0.0.1 at 2017-12-20 14:19:51 -0800
Started GET "/cable/" [WebSocket] for 127.0.0.1 at 2017-12-20 14:19:51 -0800
Successfully upgraded to WebSocket (REQUEST_METHOD: GET, HTTP_CONNECTION: Upgrade, HTTP_UPGRADE: websocket)
#<Thread:0x00007fbb8cb5d9d0@/Users/petercopter/.rbenv/versions/2.5.0-rc1/lib/ruby/gems/2.5.0/gems/actioncable-5.1.4/lib/action_cable/connection/stream_event_loop.rb:73 run> terminated with exception (report_on_exception is true):
Traceback (most recent call last):
	6: from /Users/petercopter/.rbenv/versions/2.5.0-rc1/lib/ruby/gems/2.5.0/gems/actioncable-5.1.4/lib/action_cable/connection/stream_event_loop.rb:73:in `block (2 levels) in spawn'
	5: from /Users/petercopter/.rbenv/versions/2.5.0-rc1/lib/ruby/gems/2.5.0/gems/actioncable-5.1.4/lib/action_cable/connection/stream_event_loop.rb:84:in `run'
	4: from /Users/petercopter/.rbenv/versions/2.5.0-rc1/lib/ruby/gems/2.5.0/gems/actioncable-5.1.4/lib/action_cable/connection/stream_event_loop.rb:84:in `loop'
	3: from /Users/petercopter/.rbenv/versions/2.5.0-rc1/lib/ruby/gems/2.5.0/gems/actioncable-5.1.4/lib/action_cable/connection/stream_event_loop.rb:91:in `block in run'
	2: from /Users/petercopter/.rbenv/versions/2.5.0-rc1/lib/ruby/gems/2.5.0/gems/actioncable-5.1.4/lib/action_cable/connection/stream_event_loop.rb:29:in `block in attach'
	1: from /Users/petercopter/.rbenv/versions/2.5.0-rc1/lib/ruby/gems/2.5.0/gems/actioncable-5.1.4/lib/action_cable/connection/stream_event_loop.rb:29:in `register'
/Users/petercopter/.rbenv/versions/2.5.0-rc1/lib/ruby/gems/2.5.0/gems/actioncable-5.1.4/lib/action_cable/connection/stream_event_loop.rb:29:in `lock': wrong number of arguments (given 4, expected 0) (ArgumentError)

Petercopter commented Dec 20, 2017

@eileencodes Thanks for looking into this. I've setup a new application here:
https://github.com/Petercopter/ruby_2_5_test

I used the basic ActionCable instructions to get up and running, and it appears to be pretty similar to what I have in production. I confirmed that things were working with 2.4.2 before switching over to 2.5.0, and luckily the error is readily apparent.

If you pull the application, just start server and visits /posts, you will see it. Let me know what else I can do, I'm happy to be helping.

Completed 200 OK in 251ms (Views: 241.2ms | ActiveRecord: 0.4ms)

Started GET "/cable" for 127.0.0.1 at 2017-12-20 14:19:51 -0800
Started GET "/cable/" [WebSocket] for 127.0.0.1 at 2017-12-20 14:19:51 -0800
Successfully upgraded to WebSocket (REQUEST_METHOD: GET, HTTP_CONNECTION: Upgrade, HTTP_UPGRADE: websocket)
#<Thread:0x00007fbb8cb5d9d0@/Users/petercopter/.rbenv/versions/2.5.0-rc1/lib/ruby/gems/2.5.0/gems/actioncable-5.1.4/lib/action_cable/connection/stream_event_loop.rb:73 run> terminated with exception (report_on_exception is true):
Traceback (most recent call last):
	6: from /Users/petercopter/.rbenv/versions/2.5.0-rc1/lib/ruby/gems/2.5.0/gems/actioncable-5.1.4/lib/action_cable/connection/stream_event_loop.rb:73:in `block (2 levels) in spawn'
	5: from /Users/petercopter/.rbenv/versions/2.5.0-rc1/lib/ruby/gems/2.5.0/gems/actioncable-5.1.4/lib/action_cable/connection/stream_event_loop.rb:84:in `run'
	4: from /Users/petercopter/.rbenv/versions/2.5.0-rc1/lib/ruby/gems/2.5.0/gems/actioncable-5.1.4/lib/action_cable/connection/stream_event_loop.rb:84:in `loop'
	3: from /Users/petercopter/.rbenv/versions/2.5.0-rc1/lib/ruby/gems/2.5.0/gems/actioncable-5.1.4/lib/action_cable/connection/stream_event_loop.rb:91:in `block in run'
	2: from /Users/petercopter/.rbenv/versions/2.5.0-rc1/lib/ruby/gems/2.5.0/gems/actioncable-5.1.4/lib/action_cable/connection/stream_event_loop.rb:29:in `block in attach'
	1: from /Users/petercopter/.rbenv/versions/2.5.0-rc1/lib/ruby/gems/2.5.0/gems/actioncable-5.1.4/lib/action_cable/connection/stream_event_loop.rb:29:in `register'
/Users/petercopter/.rbenv/versions/2.5.0-rc1/lib/ruby/gems/2.5.0/gems/actioncable-5.1.4/lib/action_cable/connection/stream_event_loop.rb:29:in `lock': wrong number of arguments (given 4, expected 0) (ArgumentError)
@y-yagi

This comment has been minimized.

Show comment
Hide comment
@y-yagi

y-yagi Dec 29, 2017

Member

Seems issue of nio4r. And already fixed with v2.2.0.
socketry/nio4r#179
https://github.com/socketry/nio4r/blob/master/CHANGES.md#220-2017-12-27

Please update nio4r gem. Thanks!

Member

y-yagi commented Dec 29, 2017

Seems issue of nio4r. And already fixed with v2.2.0.
socketry/nio4r#179
https://github.com/socketry/nio4r/blob/master/CHANGES.md#220-2017-12-27

Please update nio4r gem. Thanks!

@y-yagi y-yagi closed this Dec 29, 2017

@Petercopter

This comment has been minimized.

Show comment
Hide comment
@Petercopter

Petercopter Dec 29, 2017

@y-yagi Awesome, thanks! 馃憤 馃帀

Petercopter commented Dec 29, 2017

@y-yagi Awesome, thanks! 馃憤 馃帀

rohrlach pushed a commit to upstage-org/limelight that referenced this issue Mar 25, 2018

rohrlach
Address Issue
According to rails/rails#31517 updating the nio4r gem is the solution.  It appears to work.

@rohrlach rohrlach referenced this issue Mar 25, 2018

Merged

Issue #315 #316

rohrlach pushed a commit to upstage-org/limelight that referenced this issue Mar 25, 2018

Paul Rohrlach
Issue #315 (#316)
According to rails/rails#31517 updating the nio4r gem is the solution.  It appears to work.

rohrlach pushed a commit to upstage-org/limelight that referenced this issue Apr 8, 2018

Paul Rohrlach
R5-2018 (#320)
* Bump Ruby version to 2.5.0 (#311)

* Issue #312 (#313)

CVE-2018-8048

* Issue #315 (#316)

According to rails/rails#31517 updating the nio4r gem is the solution.  It appears to work.

* Issue #210 (#310)

* Table for media items with the respective shown on the tag page

* tags added into table, should be media items

* Table show, unable to get media showing in table

* Table should display backdrop, sound and stage media. Avatars not showing yet

* avatar should display in table. Table does not sort yet

* Table now sorts by name or type when clicking the column heading

* indentation fixed to show.html.erb and tags.all in show method in tags controller removed

* Removed white spacing and adjust indentation

* Remove Spaces

In HTML, there shouldn't be spaces either side of an ```=``` like you would see in Ruby or Javascript

* Update Rails 5.1.6

Minor release. Applies latest security and bug fixes

* Issue #254 (#317)

* Changed delete messages. Delete messages are now
more consistent.

* Inconsistent messages are now of the same style as other messages.

* Wording changed in delete message. "from the server"
removed and changed to "immediately"

* Fix Typo

* Issue #205 (#318)

* Changed the name of edit button to save

* Remove active class in avatar and backdrop tab

* Chat name adjusted
If the player is holding an avatar and they message on the chat, their name will be displayed as their avatar nickname
If the player is not holding an avatar then their name displayed on the chat will the their username

* Chat name adjusted
If the player is holding an avatar and they message on the chat, their name will be displayed as their avatar nickname
If the player is not holding an avatar then their name displayed on the chat will the their username

* Remove log message

* Changed variable name

* Avatar and backdrop now shows image when you click the tab

* Added new migration file
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment