Incorrect error message when mistyped validation in related association

[loqimean]

Steps to reproduce

class Parent < ApplicationRecord
  has_one :child, dependent: :destroy
end

class Child < ApplicationRecord
  belongs_to :parent
  
  valisates :something, presen: true
end

Expected behavior

Rails shows error of mistyping, like a "method_missing': undefined method valisates' for Child:Class (NoMethodError)"

Actual behavior

Instead of this I have had an error:
"Rails couldn't find a valid model for Child association. Please provide the :class_name option on the association declaration. If :class_name is already provided, make sure it's an ActiveRecord::Base subclass.

      raise NameError, msg"

And spent a lot of my time to resolve this issue by a relation changing

System configuration

Rails version: 7.0.3

Ruby version: 3.1.2

[fatkodima]

Works for me as expected. Can you create a reproducible example using https://github.com/rails/rails/blob/main/guides/bug_report_templates/active_record_main.rb or create a sample app and share with us?

[nvasilevski]

upd: 🤦 I confused expected behavior with actual behavior sections

[rafaelfranca]

I think we can't reproduce outside of a Rails app. It is related to autoloading and probably only happens when the Parent class is loaded before the Child class. It happens in this code here

rails/activerecord/lib/active_record/reflection.rb

Lines 421 to 443 in 28b5771

	def compute_class(name)
	if polymorphic?
	raise ArgumentError, "Polymorphic associations do not support computing the class."
	end
	msg = <<-MSG.squish
	Rails couldn't find a valid model for #{name} association.
	Please provide the :class_name option on the association declaration.
	If :class_name is already provided, make sure it's an ActiveRecord::Base subclass.
	MSG
	begin
	klass = active_record.send(:compute_type, name)
	unless klass < ActiveRecord::Base
	raise ArgumentError, msg
	end
	klass
	rescue NameError
	raise NameError, msg
	end
	end

.

I'm pretty sure we have another issue related to this. Loading Child will raise an exception that then we transform in NameError, and then we show that exception message instead of the original NoMethodError. Maybe we should include the original exception message in our message.

[ghiculescu]

I made a test app to replicate the issue. And this is the error page I got:

If you click on the cause it expands to show the original error:

This is with:

(I tried with Ruby 2.7 and got the same 👍 )

@loqimean did you see a similar error page?

[loqimean]

I made a test app to replicate the issue. And this is the error page I got:

If you click on the cause it expands to show the original error:

This is with: (I tried with Ruby 2.7 and got the same 👍 )

@loqimean did you see a similar error page?

yeah, me too