Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

ActiveRecord Readme correction #761

Closed
lighthouse-import opened this Issue May 16, 2011 · 0 comments

Comments

Projects
None yet
1 participant

Imported from Lighthouse. Original ticket at: http://rails.lighthouseapp.com/projects/8994/tickets/6038
Created by y_feldblum (at yahoo) - 2011-02-19 09:28:13 UTC

The following code is in the ActiveRecord readme file:

class CommentObserver < ActiveRecord::Observer
  def after_create(comment) # is called just after Comment#save
    Notifications.deliver_new_comment("david@loudthinking.com", comment)
  end
end

The middle line appears to use the old ActionMailer API, and should be updated to use the new ActionMailer API.

hisas pushed a commit to hisas/rails that referenced this issue May 9, 2017

Merge pull request #761 from zendesk/grosser/default-char
Expose `Mail::Message.default_charset = ...` to set the default charset for new messages. Defaults to `'UTF-8'`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment