Redirection loop for controller#location with redirect_to

[terlar]

If I have a controller with the action location and inside that action I will do a redirect_to another url. Then I will get an infinite redirection loop.

routes.rb

resources :fruits

namespace :select do
  get :location
end

fruits_controller.rb

class FruitsController < ApplicationController
  def new
    # Do stuff
  end
end

select_controller.rb

class SelectController < ApplicationController
  def location
    if true
      return redirect_to new_fruit_url
    end
  end
end

[senny]

I investigated and the problem seems to be that location is a method on ActionController::Metal. I think it should not be possible to define it as an action method since this leads to the behavior you described.

Currently the available action_methods are defined as follows:

def action_methods
  @action_methods ||= begin
    # All public instance methods of this class, including ancestors
    methods = (public_instance_methods(true) -
      # Except for public instance methods of Base and its ancestors
      internal_methods +
      # Be sure to include shadowed public instance methods of this class
      public_instance_methods(false)).uniq.map { |x| x.to_s } -
      # And always exclude explicitly hidden actions
      hidden_actions.to_a

    # Clear out AS callback method pollution
    Set.new(methods.reject { |method| method =~ /_one_time_conditions/ })
  end
end

@steveklabnik @rafaelfranca what do you think?

[steveklabnik]

Yep, this isn't a bug, this is overriding a method in the controller. An unfortunate collision.