Rails 4 leave brackets in urls

[madmax]

In rails 4 when route has multiple optional parameters url helper add closing bracket to path/url

Example:

get 'post(/:action(/:id))' => 'posts#index', as: :posts

and run in console:

>> app.posts_path
=> "/post)"

Tested on Rails 4.0.0.beta1 && master branch

[steveklabnik]

/cc @pixeltrix

[senny]

I'll take a look at this one and report back.

[senny]

Could be related to #9504

[senny]

I think it's best to wait for @pixeltrix before I invest too much time. He seems to be working on the optional params code in the router.

[madmax]

@senny #9504 is broken in rails 3.2 (and probably in 4.0) but this is only in rails >= 4

[pixeltrix]

Pretty sure this is related to the changes to optimised route generation that @tenderlove made since bypassing the url helper generates cleanly and specifying an action works as well, e.g.:

>> app.url_for :controller => 'posts', :action => 'index', :only_path => true
=> "/post"
>> app.posts_path :action => 'index'
=> "/post"

I'll investigate further.

[pixeltrix]

Apologies to @tenderlove - the problem is in the original optimised path helper code committed by @josevalim in d7014bc. The regexp /\([^\)]*\)/ is used to strip out optional segments in the path but obviously won't handle nested optional segments.

A quick and dirty fix is to use the regexp /\([^\)]*\)+/ which will gather up the trailing parentheses but I'm looking for something better.

[pixeltrix]

That should fix it and be a little bit quicker also since we're not having to gsub the path 😄

[senny]

yay! Thanks @pixeltrix 💛

[madmax]

Thanks @pixeltrix !