Do not invoke callbacks when delete_all is called #10604
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Method `delete_all` should not be invoking callbacks and this feature was deprecated in Rails 4.0. This is being removed. `delete_all` will continue to honor the `:dependent` option. However if `:dependent` value is `:destroy` then the default deletion strategy for that collection will be applied. User can also force a deletion strategy by passing parameter to `delete_all`. For example you can do `@post.comments.delete_all(:nullify)`
|
This PR also removes deprecation message. Please take a look. Will rebase if things look good. /cc @rafaelfranca @carlosantoniodasilva |
rafaelfranca
added a commit
that referenced
this pull request
Jul 2, 2013
…ll_callbacks Do not invoke callbacks when delete_all is called Conflicts: activerecord/CHANGELOG.md
kamipo
added a commit
to kamipo/rails
that referenced
this pull request
Oct 29, 2016
…delete` The internal `:dependent` option was introduced at rails#10604. But currently unused.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Method
delete_allshould not be invoking callbacks and thisfeature was deprecated in Rails 4.0. This is being removed.
delete_allwill continue to honor the:dependentoption. Howeverif
:dependentvalue is:destroythen the default deletionstrategy for that collection will be applied.
User can also force a deletion strategy by passing parameter to
delete_all. For example you can do@post.comments.delete_all(:nullify)