Revise 'sqlite3:' URL handling for smoother upgrades #14569

Merged
merged 2 commits into from Apr 3, 2014

Conversation

Projects
None yet
2 participants
@matthewd
Member

matthewd commented Apr 2, 2014

@rafaelfranca as discussed. I think. 馃槃

matthewd added some commits Apr 2, 2014

Revise 'sqlite3:' URL handling for smoother upgrades
Restore the 4.0 behaviour for 'sqlite3:///', but deprecate it. We'll
change to the absolute-path interpretation in 4.2.

The current "correct" spellings for in-memory, relative, and absolute
URLs, respectively, are:

    sqlite3::memory:
    sqlite3:relative/path
    sqlite3:/full/path

Substantially reverses/defers fbb79b5.
Uncovered by @guilleiguaran while investigating #14495, though that
sounds like a different issue.
Complete change of `sqlite3:///` path handling
That which was now relative is now absolute.
+ sqlite3:/full/path
+
+ The previous spelling (`sqlite3:///relative/path`) continues to work
+ as it did in Rails 4.0, but with a deprecation warning: in the next

This comment has been minimized.

@rafaelfranca

rafaelfranca Apr 2, 2014

Member

Was the deprecation warning implemented? I could not find in the diff

@rafaelfranca

rafaelfranca Apr 2, 2014

Member

Was the deprecation warning implemented? I could not find in the diff

This comment has been minimized.

@matthewd

matthewd Apr 2, 2014

Member

For anyone else reading this:

The PR contains two commits; the first introduces the deprecation while maintaining the historical behaviour, the second then removes the deprecation and changes to the new/desirable behaviour. Obviously, only the first one should be backported.

@matthewd

matthewd Apr 2, 2014

Member

For anyone else reading this:

The PR contains two commits; the first introduces the deprecation while maintaining the historical behaviour, the second then removes the deprecation and changes to the new/desirable behaviour. Obviously, only the first one should be backported.

@rafaelfranca rafaelfranca added this to the 4.1.0 milestone Apr 2, 2014

rafaelfranca added a commit that referenced this pull request Apr 3, 2014

Merge pull request #14569 from matthewd/sqlite_relative_deprecated
Revise 'sqlite3:' URL handling for smoother upgrades

Conflicts:
	activerecord/CHANGELOG.md

@rafaelfranca rafaelfranca merged commit 0a99fdd into rails:master Apr 3, 2014

1 of 2 checks passed

default The Travis CI build could not complete due to an error
Details
continuous-integration/travis-ci The Travis CI build passed
Details

@matthewd matthewd deleted the matthewd:sqlite_relative_deprecated branch Aug 22, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment