Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revise 'sqlite3:' URL handling for smoother upgrades #14569

Merged
merged 2 commits into from Apr 3, 2014

Conversation

matthewd
Copy link
Member

@matthewd matthewd commented Apr 2, 2014

@rafaelfranca as discussed. I think. 馃槃

matthewd added 2 commits Apr 2, 2014
Restore the 4.0 behaviour for 'sqlite3:///', but deprecate it. We'll
change to the absolute-path interpretation in 4.2.

The current "correct" spellings for in-memory, relative, and absolute
URLs, respectively, are:

    sqlite3::memory:
    sqlite3:relative/path
    sqlite3:/full/path

Substantially reverses/defers fbb79b5.
Uncovered by @guilleiguaran while investigating rails#14495, though that
sounds like a different issue.
That which was now relative is now absolute.
sqlite3:/full/path

The previous spelling (`sqlite3:///relative/path`) continues to work
as it did in Rails 4.0, but with a deprecation warning: in the next
Copy link
Member

@rafaelfranca rafaelfranca Apr 2, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was the deprecation warning implemented? I could not find in the diff

Copy link
Member Author

@matthewd matthewd Apr 2, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For anyone else reading this:

The PR contains two commits; the first introduces the deprecation while maintaining the historical behaviour, the second then removes the deprecation and changes to the new/desirable behaviour. Obviously, only the first one should be backported.

@rafaelfranca rafaelfranca added this to the 4.1.0 milestone Apr 2, 2014
rafaelfranca added a commit that referenced this pull request Apr 3, 2014
Revise 'sqlite3:' URL handling for smoother upgrades

Conflicts:
	activerecord/CHANGELOG.md
@rafaelfranca rafaelfranca merged commit 0a99fdd into rails:master Apr 3, 2014
@matthewd matthewd deleted the sqlite_relative_deprecated branch Aug 22, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants