Revise 'sqlite3:' URL handling for smoother upgrades #14569
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Restore the 4.0 behaviour for 'sqlite3:///', but deprecate it. We'll
change to the absolute-path interpretation in 4.2.
The current "correct" spellings for in-memory, relative, and absolute
URLs, respectively, are:
sqlite3::memory:
sqlite3:relative/path
sqlite3:/full/path
Substantially reverses/defers fbb79b5.
Uncovered by @guilleiguaran while investigating rails#14495, though that
sounds like a different issue.
That which was now relative is now absolute.
| sqlite3:/full/path | ||
|
|
||
| The previous spelling (`sqlite3:///relative/path`) continues to work | ||
| as it did in Rails 4.0, but with a deprecation warning: in the next |
There was a problem hiding this comment.
Was the deprecation warning implemented? I could not find in the diff
There was a problem hiding this comment.
For anyone else reading this:
The PR contains two commits; the first introduces the deprecation while maintaining the historical behaviour, the second then removes the deprecation and changes to the new/desirable behaviour. Obviously, only the first one should be backported.
rafaelfranca
added a commit
that referenced
this pull request
Apr 3, 2014
Revise 'sqlite3:' URL handling for smoother upgrades Conflicts: activerecord/CHANGELOG.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@rafaelfranca as discussed. I think. 😄