Remove dead test code for unsupported adapters #15137
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
SQL Server I know we still support. The others are unknown. Maybe we should ask the adapter maintainers before removing. Thank you for working on this. |
|
thanks, should be fine with AR-JDBC ... good that you're keeping Oracle (for now). Sybase almost no users, Firebird has some users but our support is kind of "not 1st-class" ... definitely no need for support in Rails tests. |
|
SQL Server is still used. Just released a 4.0 version of it yesterday and hope to work on the 4.1 version soon. This looks good to me. |
|
Seems good. Could you squash and rebase it? |
|
@rafaelfranca Done. |
rafaelfranca
added a commit
that referenced
this pull request
May 17, 2014
Remove dead test code for unsupported adapters
kamipo
added a commit
to kamipo/rails
that referenced
this pull request
Apr 11, 2020
Related rails#15137. Firebird related code is already removed in rails#15137. We have two `current_adapter?(:DB2Adapter)` in tests, but the adapter is no longer maintained (last release is November 15, 2012). https://rubygems.org/gems/db2 Yet another (latest) DB2 adapter (`IBM_DBAdapter`) might support Rails 5.0.7, but apparently do not work for Rails 5.2. https://rubygems.org/gems/ibm_db We have few lines mention about DB2 in the doc, but now there is no worth for almost all current users.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.