Integrate ActiveJob / DeliverLater / GlobalID with Rails - #16485
Conversation
…embedded in there too
…sques expectation of a class variable
This is not only easier to read, but it'll also properly raise an ArgumentError rather than a NoMethodError when called with no arguments. It also allocates 4 fewer objects per call (8 down from 12), and is about 50% faster according to a quick benchmark.
Clean up JobWrappers::ResqueWrapper.perform
Add Sidekiq adapter/wrapper fixes rails#3
Lazy-load adapters, fixes rails#6
…l raise exactly the error we want to communicate anyway. Also use the load path, so we can allow plugins, rather than requre_relative
Implemented delayed_job support
|
@tenderlove We have integration tests rails/activejob#102 but: |
…figure ActiveJob from app.config.active_job
|
Not related to the PR itself, but I was wondering: what makes some part of Rails "active_" or "action_"? "Active record" was an existing term of course, but what makes ActionMailer and ActiveJob, action and active, relatively? |
|
I've used Action for anything that is frontend aimed (controller/views), Active for backend (models etc).
|
|
All right, curiosity satisfied :) |
Integrate ActiveJob / DeliverLater / GlobalID with Rails
|
🤘 |
|
@tenderlove here are the integration tests Cristian Bica On Fri, Aug 15, 2014 at 5:07 AM, Aaron Patterson notifications@github.com
|
|
👍 |
|
@mperham I am looking at the pull request here rails/activejob#35 |
|
@cristianbica thanks for the explanation, now I see. |
WIP.