Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrate ActiveJob / DeliverLater / GlobalID with Rails #16485

Merged
merged 230 commits into from Aug 17, 2014

Conversation

dhh
Copy link
Member

@dhh dhh commented Aug 12, 2014

WIP.

dhh and others added 30 commits May 18, 2014 11:44
This is not only easier to read, but it'll also properly raise an ArgumentError rather than a NoMethodError when called with no arguments.

It also allocates 4 fewer objects per call (8 down from 12), and is about 50% faster according to a quick benchmark.
Clean up JobWrappers::ResqueWrapper.perform
 Add Sidekiq adapter/wrapper fixes rails#3
…l raise exactly the error we want to communicate anyway. Also use the load path, so we can allow plugins, rather than requre_relative
@cristianbica
Copy link
Member

@tenderlove We have integration tests rails/activejob#102 but:
I wanted to drop them seuros/actionmailer-deliver_later#6 (comment)
@ddh said no :) seuros/actionmailer-deliver_later#6 (comment)
@rafaelfranca said to make separate PR with them https://github.com/seuros/rails/issues/1#issuecomment-51945362
So I'll make the PR once we get this PR merged

@DouweM
Copy link
Contributor

DouweM commented Aug 16, 2014

Not related to the PR itself, but I was wondering: what makes some part of Rails "active_" or "action_"? "Active record" was an existing term of course, but what makes ActionMailer and ActiveJob, action and active, relatively?

@dhh
Copy link
Member Author

dhh commented Aug 16, 2014

I've used Action for anything that is frontend aimed (controller/views), Active for backend (models etc).

On Aug 16, 2014, at 12:20, Douwe Maan notifications@github.com wrote:

Not related to the PR itself, but I was wondering: what makes some part of Rails "active_" or "action_"? "Active record" was an existing term of course, but what makes ActionMailer and ActiveJob, action and active, relatively?


Reply to this email directly or view it on GitHub.

@DouweM
Copy link
Contributor

DouweM commented Aug 16, 2014

All right, curiosity satisfied :)

dhh added a commit that referenced this pull request Aug 17, 2014
Integrate ActiveJob / DeliverLater / GlobalID with Rails
@dhh dhh merged commit 49c9f85 into rails:master Aug 17, 2014
@jeremy
Copy link
Member

jeremy commented Aug 18, 2014

🤘

@cristianbica
Copy link
Member

@tenderlove here are the integration tests
#16541

Cristian Bica

On Fri, Aug 15, 2014 at 5:07 AM, Aaron Patterson notifications@github.com
wrote:

Where does the test harness set up redis queues and pg tables for testing
the different queues? I can't seem to find it.


Reply to this email directly or view it on GitHub
#16485 (comment).

@zhouguangming
Copy link
Contributor

👍

@jGRUBBS
Copy link

jGRUBBS commented Aug 27, 2014

@mperham I am looking at the pull request here rails/activejob#35
I still don't see any rationale behind removing the later method in the sucker_punch_adapter unless you have any reason as to why it was removed, could it be added back?

@cristianbica
Copy link
Member

@jGRUBBS it was proposed again in rails/rails #16643 but because Sucker Punch does not have a persistent store we decided not to accept it.

@jGRUBBS
Copy link

jGRUBBS commented Aug 27, 2014

@cristianbica thanks for the explanation, now I see.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet