ActiveJob: queue_adapter can be inherited #16992

tamird · 2014-09-20T23:32:15Z

lukaszx0 · 2014-09-24T05:02:09Z

activejob/lib/active_job/queue_adapters/test_adapter.rb

+            performed_jobs << {job: job.class, args: job.arguments, queue: job.queue_name}
+            job.perform_now
+          else
+            enqueued_jobs << {job: job.class, args: job.arguments, queue: job.queue_name}


We have 4 lines like this. Maybe let's return it from a method like job_hash(job) ?

Actually even more natural would be job.to_hash

cristianbica · 2014-09-24T05:27:56Z

The test adapter was made like this so we can run tests in parallel. @seuros you worked on this
Anyway if you are going to do this make a separate PR

cristianbica · 2014-09-24T05:31:38Z

activejob/lib/active_job/queue_adapter.rb

 require 'active_support/core_ext/string/inflections'

 module ActiveJob
  module QueueAdapter
    extend ActiveSupport::Concern

+    included do
+      class_attribute :_queue_adapter, instance_accessor: false, instance_predicate: false


Please rename _queue_adapter to something else _queue_adapter_class or even queue_adapter_class to be more clear

It's not always a class, though. It may be a callable. I'll change the name to reflect that.

cristianbica · 2014-09-24T05:38:27Z

Here's the PR when we switch the test adapter to instance methods #16724 (diff)

seuros · 2014-09-24T08:55:42Z

activejob/test/cases/test_helper_test.rb

@@ -7,6 +7,7 @@

 class EnqueuedJobsTest < ActiveJob::TestCase
  setup { queue_adapter.perform_enqueued_at_jobs = true }
+  teardown { queue_adapter.perform_enqueued_at_jobs = false }


We don't need these teardowns. The test adapter sould to allow parallel test instantiated for every test

Not anymore, it's a singleton now. See existing discussion in this PR.

cristianbica · 2014-09-24T20:15:25Z

Ok. So ... as discussed the ability to pass a proc to queue_adapter is still under discussion so I suggest to leave this PR with the initial scope of being able to override sub-jobs adapters and start a new PR with the proc thing.
On the other hand we need to document the current change so we need to add documentation to queue_adapter= and queue_adapter. What would be nicer is if you have some time to update the AJ guide :)

cristianbica · 2014-09-24T20:15:49Z

Also you need to rebase before we're ready to merge

cristianbica · 2014-09-24T21:21:28Z

I meant to rebase so you can squash your commits

seuros · 2014-09-24T21:37:37Z

Then you should split them into multiple PRs.
I don't like the singleton conversion. we had it like that and changed it to instance . cc @jeremy

lukaszx0 · 2014-09-24T21:52:03Z

No need to squash or split it into multiple PRs.

Looks good to me 👍

jeremy · 2014-09-25T17:53:42Z

I'd keep TestAdapter as a class with a single instance rather than switching to using a class object as the adapter. Nice cleanup of the adapter internals in either case.

cristianbica · 2014-10-08T07:02:13Z

@tamir this is the same as #16977 so we can close #16977, right?

tamir · 2014-10-08T07:10:55Z

I was erroneously ccd. the mail should have gone to @tamird i think.

On 08 Oct 2014, at 09:02, Cristian Bica notifications@github.com wrote:

@tamir this is the same as #16977 so we can close #16977, right?

—
Reply to this email directly or view it on GitHub.

jeremy · 2015-03-12T03:29:09Z

activejob/lib/active_job/test_helper.rb

+        test_adapter = ActiveJob::QueueAdapters::TestAdapter.new
+
+        @old_queue_adapters = (ActiveJob::Base.subclasses << ActiveJob::Base).select do |klass|
+          klass.respond_to?(:queue_adapter)


Every ActiveJob::Base subclass will respond to :queue_adapter since it's a singleton method on Base

derp, you're right. fixed

jeremy · 2015-03-12T04:55:18Z

activejob/lib/active_job/test_helper.rb

+          [klass, klass.queue_adapter].tap do
+            klass.queue_adapter = test_adapter
+          end
+        end


Since class attributes no longer inherit from superclass once they're written, assigning #queue_adapter on classes the didn't have it explicitly set will leak side effects between test cases (since changing a superclass attr won't be inherited by its subclass afterward)

great catch, fixed

jeremy · 2015-03-12T05:43:59Z

activejob/lib/active_job/test_helper.rb

+          # only override explicitly set adapters, a quirk of `class_attribute`
+          klass.singleton_class.public_instance_methods(false).include?(:_queue_adapter)
+        end.map do |klass|
+          [klass, klass._queue_adapter].tap do


Prefer to use the public-API reader?

This allows different `queue_adapters` to be used in each `ActiveJob` class heirarchy. Previously, all subclasses used a single global queue adapter.

ActiveJob: queue_adapter can be inherited

cristianbica · 2015-03-12T08:56:25Z

❤️ took a few months to get this merged :)

trungpham · 2015-03-12T23:00:47Z

👍

rebyn · 2015-04-13T05:56:54Z

I'm not seeing this feature being mentioned in the Basics guide. Or we have an Advanced guide somewhere that I don't know :)?

I think this is cool and deserves a mention. Should I submit a PR or has anyone worked on this already?

benoitongit · 2016-03-07T04:52:19Z

👍
Really cool, thanks! Would be great to add it in the basic guide, it took some time to know it was possible.

jrochkind · 2017-07-21T00:22:00Z

Is code merged in such that it's possible to have different queue adapters for different jobs? (and if so beginning in what Rails version)

I got here following a trail of links between issues and PRs here and in ActiveJob. And the disussion and statuses here make me think this is now possible. But I have no idea how to do it!

If I'm on the right track, could anyone post an example here? If I get an example, I will try to play with it and understand it and do a doc PR demo'ing it in the right place. (If it's already in the docs but I just haven't found it, would very much appreciate if you wanted to point me there!).

jrochkind · 2017-07-21T00:23:27Z

Nevermind, just found it in the guide! "You can also configure your backend on a per job basis." Okay! Great!

steveburkett · 2017-10-04T16:10:22Z

does anyone have a "patch" i can use in my rails 4.2 app to get this to work?

Rails 5+ allows to set queue adapter per job class rails/rails#16992

tamird force-pushed the configurable-job-queue-adapter branch from a91699a to 3092006 Compare September 24, 2014 03:45

tamird mentioned this pull request Sep 24, 2014

allow overriding sub job queue_adapter without affecting the base job or sibling job #16968

Closed

tamird force-pushed the configurable-job-queue-adapter branch 2 times, most recently from b0f3a44 to 4275f40 Compare September 24, 2014 04:35

tamird changed the title ~~allow overriding sub job queue_adapter without affecting the base job or...~~ AJ::Base.queue_adapter improvements Sep 24, 2014

tamird force-pushed the configurable-job-queue-adapter branch from 4275f40 to 208c9b9 Compare September 24, 2014 04:48

lukaszx0 reviewed Sep 24, 2014
View reviewed changes

lukaszx0 added the activejob label Sep 24, 2014

tamird force-pushed the configurable-job-queue-adapter branch from 208c9b9 to 22118ce Compare September 24, 2014 05:14

cristianbica reviewed Sep 24, 2014
View reviewed changes

tamird force-pushed the configurable-job-queue-adapter branch from 22118ce to 1d5b389 Compare September 24, 2014 05:42

tamird mentioned this pull request Sep 24, 2014

[ActiveJob] TestCase #16724

Merged

seuros reviewed Sep 24, 2014
View reviewed changes

tamird force-pushed the configurable-job-queue-adapter branch 4 times, most recently from d933fb3 to 6f851ec Compare September 24, 2014 16:36

tamird force-pushed the configurable-job-queue-adapter branch from 6f851ec to c80f403 Compare February 23, 2015 16:29

jeremy reviewed Mar 12, 2015
View reviewed changes

tamird force-pushed the configurable-job-queue-adapter branch from 9515e8a to cbaa77d Compare March 12, 2015 03:37

jeremy reviewed Mar 12, 2015
View reviewed changes

tamird force-pushed the configurable-job-queue-adapter branch 3 times, most recently from fabae1a to 2a30528 Compare March 12, 2015 05:42

jeremy reviewed Mar 12, 2015
View reviewed changes

ActiveJob::Base#queue_adapter is now a class_attribute

1f8558f

This allows different `queue_adapters` to be used in each `ActiveJob` class heirarchy. Previously, all subclasses used a single global queue adapter.

tamird force-pushed the configurable-job-queue-adapter branch from 2a30528 to 1f8558f Compare March 12, 2015 05:46

jeremy added a commit that referenced this pull request Mar 12, 2015

Merge pull request #16992 from square/configurable-job-queue-adapter

202c68c

ActiveJob: queue_adapter can be inherited

jeremy merged commit 202c68c into rails:master Mar 12, 2015

tamird deleted the configurable-job-queue-adapter branch March 12, 2015 07:22

jeremy mentioned this pull request Mar 12, 2015

ActiveJob overriding queue_adapter in child class affect parent class #16960

Closed

rafaelfranca modified the milestones: 5.0.0 [temp], 5.0.0 Dec 30, 2015

y-yagi mentioned this pull request Sep 5, 2016

use descendants to get class that inherited ActiveJob::Base #26391

Merged

lmansur mentioned this pull request Aug 29, 2019

ActiveJob: changing queue_name_prefix in one Job affects all other jobs. #37084

Closed

sharshenov added a commit to veeqo/advanced-sneakers-activejob that referenced this pull request Apr 6, 2020

Define consumers if job queue adapter is :advanced_sneakers

07d979f

Rails 5+ allows to set queue adapter per job class rails/rails#16992

sharshenov added a commit to veeqo/advanced-sneakers-activejob that referenced this pull request Apr 6, 2020

Define consumers if job queue adapter is :advanced_sneakers

6e76b3a

Rails 5+ allows to set queue adapter per job class rails/rails#16992

sharshenov added a commit to veeqo/advanced-sneakers-activejob that referenced this pull request Apr 6, 2020

Define consumers if job queue adapter is :advanced_sneakers

3de215e

Rails 5+ allows to set queue adapter per job class rails/rails#16992

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

ActiveJob: queue_adapter can be inherited #16992

ActiveJob: queue_adapter can be inherited #16992

tamird commented Sep 20, 2014

lukaszx0 Sep 24, 2014

lukaszx0 Sep 24, 2014

tamird Sep 24, 2014

cristianbica commented Sep 24, 2014

cristianbica Sep 24, 2014

tamird Sep 24, 2014

cristianbica commented Sep 24, 2014

seuros Sep 24, 2014

tamird Sep 24, 2014

cristianbica commented Sep 24, 2014

cristianbica commented Sep 24, 2014

cristianbica commented Sep 24, 2014

seuros commented Sep 24, 2014

lukaszx0 commented Sep 24, 2014

jeremy commented Sep 25, 2014

cristianbica commented Oct 8, 2014

tamir commented Oct 8, 2014

jeremy Mar 12, 2015

tamird Mar 12, 2015

jeremy Mar 12, 2015

tamird Mar 12, 2015

jeremy Mar 12, 2015

tamird Mar 12, 2015

cristianbica commented Mar 12, 2015

trungpham commented Mar 12, 2015

rebyn commented Apr 13, 2015

benoitongit commented Mar 7, 2016

jrochkind commented Jul 21, 2017 •

edited

Loading

jrochkind commented Jul 21, 2017

steveburkett commented Oct 4, 2017

ActiveJob: queue_adapter can be inherited #16992

ActiveJob: queue_adapter can be inherited #16992

Conversation

tamird commented Sep 20, 2014

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

cristianbica commented Sep 24, 2014

Choose a reason for hiding this comment

Choose a reason for hiding this comment

cristianbica commented Sep 24, 2014

Choose a reason for hiding this comment

Choose a reason for hiding this comment

cristianbica commented Sep 24, 2014

cristianbica commented Sep 24, 2014

cristianbica commented Sep 24, 2014

seuros commented Sep 24, 2014

lukaszx0 commented Sep 24, 2014

jeremy commented Sep 25, 2014

cristianbica commented Oct 8, 2014

tamir commented Oct 8, 2014

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

cristianbica commented Mar 12, 2015

trungpham commented Mar 12, 2015

rebyn commented Apr 13, 2015

benoitongit commented Mar 7, 2016

jrochkind commented Jul 21, 2017 • edited Loading

jrochkind commented Jul 21, 2017

steveburkett commented Oct 4, 2017

jrochkind commented Jul 21, 2017 •

edited

Loading