Deprecate string options in URL helpers

[mrgilman]

Fixes #16958

I pretty much implemented @bronzle's fix in the issue comments, so he should have credit too.

[zzak]

I think this would need a changelog

[sgrif]

If you want to credit someone else, put both names in the changelog, and at the bottom of the commit message put [your handle & their handle]

[sgrif]

Should this be a set?

[bronzle]

Probably a good idea.

[mrgilman]

Thanks for the feedback! Made the suggested changes and added a changelog entry.

[rafaelfranca]

I pretty much implemented @bronzle's fix in the issue comments, so he should have credit too.

❤️

[rafaelfranca]

We have a pretty complex logic here without test. For example, why were are using ||=? Why we need to check if value is present?

I'd add tests for these cases to make sure we don't have regressions on this code.

[sgrif]

This looks good to me

[rafaelfranca]

Maybe it would be better to write

if options && (deprecated_string_options = options & DEPRECATED_STRING_OPTIONS)

and we use the deprecated_string_options variable to print the correct message and to iterate on the each loop.

This way to deleting an option that doesn't existe there.

[sgrif]

That would need to be on the keys specifically. I think that'd be more readable on two lines, as well. :)

[rafaelfranca]

Does it need to be a set now?

[sgrif]

Nope. I'm about to merge, will fix as I merge.

[sgrif]

Gah... We tried to update the changelog format at the same time. This was merged.

[heaven]

Something is wrong with this:

admin_dashboard_path(params)

Where params is an instance of ActionController::Parameters, produces:

DEPRECATION WARNING: Calling URL helpers with string keys controller, action is deprecated. ...
/dashboard

[agis]

@heaven Indeed. Follow the discussion in #21648.