A correction in Rails 4.2.0 engine document #19024
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Missing `@` [ci skip]
Remove unused line
Add `auto_increment?` instead of `extra == 'auto_increment'`
…llation Respect the database default charset for `schema_migrations` table.
If timestamp column have the precision, it need to format according to the precision of timestamp column.
…esql_timestamp_column Fix rounding problem for PostgreSQL timestamp column
Added by 101c19f.
In match_head_routes, deleted the routes in which request.request_method was empty (matches all HTTP verbs) when responding to a HEAD request. This prevents catch-all routes (such as Racks) from intercepting the HEAD request. Fixes #18698
that complements the `start`parameter to specify where to stop batch processing
[ci skip]
This removes the following warning: rails/railties/lib/rails/generators/rails/plugin/plugin_generator.rb:321: warning: shadowing outer local variable - content
Explicitly ignored wildcard verbs from head_routes
This removes the following warning:
/GitHub/rails/actionview/lib/action_view/helpers/tags/translator.rb:19: warning: private attribute?
This removes the following warning: railties/test/generators/named_base_test.rb:9: warning: method redefined; discarding old pluralize_table_names activesupport/lib/active_support/core_ext/class/attribute.rb:86: warning: previous definition of pluralize_table_names was here railties/test/generators/named_base_test.rb:9: warning: method redefined; discarding old pluralize_table_names= activesupport/lib/active_support/core_ext/class/attribute.rb:83: warning: previous definition of pluralize_table_names= was here
…rator Remove warning from Plugin Generator
…named-base-test Remove warning from generator named base test
The default of the global might change. It's better to reset it to what it was than a hardcoded value.
By default the foreign key will remain set with the parent id after destroy is fired.
An array type is a part of `sql_type`
…nslator Remove warning from ActionView::Helpers::Tags::Translator
Significantly faster than `SimpleDelegator`.
Document lazy lookup behavior for controllers [ci skip]
…umentation_fix Documentation Fix: Corrects explanation of what happens when dependent is not set
The various databases don't actually need significantly different handling for this behavior, and they can achieve it without knowing about the type of the object. The old implementation was returning a string, which will cause problems such as breaking TZ aware attributes, and making it impossible for the adapters to supply their logic for time objects.
Format the time string according to the precision of the time column
mail_to helper method fix
Always reset changed attributes in becomes
…-comment Fix cache_helper comment ERB typo
…case-for-comment-consistency Active Job Guide: Use sentence case for consistency in comments [ci skip]
Simplify find_by_statement_cache interaction
Move the `validate!` method to `ActiveModel::Validations`.
Isolate access to @associations_cache and @aggregations_cache to the Associations and Aggregations modules, respectively.
These methods are nodoc so we should not document them.
Don't use shorthand match on routes with inappropriate symbols
move cache_digests rake methods into their own namespace
…Request#request_id
ActiveModel::Errors
The testing of error messages have been implemented wrongly a few times. This is an attempt to fix it. For example, some of these test should have failed with the new code. The reason they are not failling with the new string is the fact they were not being tested beforehand.
Error message testing fix
It's actually #validates_uniqueness_of that can generate a race condition rather than #validates_presence_of.
Fix #has_secure_token documentation
senny
added a commit
that referenced
this pull request
Feb 21, 2015
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ch4.3.2 in Get started with engine, it says:
class Blorgh::ApplicationController < ApplicationController
end
The above code causes error in rspec:
c:/Ruby200/lib/ruby/gems/2.0.0/gems/activesupport-4.2.0/lib/active_support/dependencies.rb:492:in `load_missing_constant': Circular dependency detected while autoloading con
stant Test4::ApplicationController (RuntimeError)
The correct format should be:
class Blorgh::ApplicationController < ::ApplicationController
end
Thanks.