Require only necessary concurrent-ruby classes. #22185
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR has two changes, which I will happily separate into two PRs if that would be preferred. The two changes are:
require
statements to only load necessary files from concurrent-ruby1.0.0.pre5
This is the last planned pre-release of concurrent-ruby. There are no new features, just performance improvements and a few refinements to the internal synchronization layer and associated memory model. We hope to release 1.0.0 fairly soon, once our biggest users have upgraded to pre5.
Updated require statements
Based on a recommendation by @jeremy in a concurrent-ruby issue.
For historical reasons, most of c-r doesn't use
autoload
(though we plan to change this in 2.0). By requiring the entire gem we unintentionally added unnecessary delay to Rails loading. Internally we have been very judicious in using explicit requires in all files. This makes it possible to include only the required c-r components. This update narrows all require statements to the minimum necessary. This should improve load time for all users.