make rake proxy work in rails engines #23169
Conversation
|
r? @matthewd (@rails-bot has picked a reviewer for you, use r? to override) |
|
cc @kaspth |
| end | ||
| end | ||
| end | ||
| end |
There was a problem hiding this comment.
Why can't we reuse the proxy from main Rails?
There was a problem hiding this comment.
I thought too much or reuse, but it is almost the same when the review.
I'm sorry, and then modified to reuse the rake_proxy of Rails.
y-yagi
force-pushed
the
rake_proxy_in_engine
branch
3 times, most recently
from
22b6013 to
6384cca
Compare
| * Make rake proxy work in Rails engines. | ||
|
|
||
| *Yuji Yaginuma* | ||
|
|
There was a problem hiding this comment.
Don't think this is CHANGELOG worthy, let's assume it worked in engines always.
|
Please rebase and squash your commits too 😁 |
| Rake.application.init('rails') | ||
| Rake.application.load_rakefile | ||
| @rake_tasks = Rake.application.tasks.select(&:comment) | ||
| end |
There was a problem hiding this comment.
Isn't rake_tasks included from the Rails::RakeProxy?
There was a problem hiding this comment.
Rails::RakeProxy#rake_tasks has become a prerequisite of the code that uses the Rails application, did not work for as it is the case of the Rails Engine, it was defined separately.
y-yagi
force-pushed
the
rake_proxy_in_engine
branch
from
6384cca to
3ffa5a1
Compare
|
Thanks for reviewing! Rebase and squash commits :) |
make rake proxy work in rails engines
|
Thanks! |
1 similar comment
|
Thanks! |
To avoid confusion, even Rails engines, I think that it may be able to run the rake task over the rails command. How about?