Action Cable: client side 💅 #24039
Action Cable: client side 💅 #24039
Conversation
#getConfig was implmented as general utility for reading action-cable-* meta tags (hence the `name` argument). Introduced in 8b69f1e.
|
r? @senny (@rails-bot has picked a reviewer for you, use r? to override) |
| @identifier = JSON.stringify(params) | ||
| extend(this, mixin) | ||
| @subscriptions.add(this) |
There was a problem hiding this comment.
Where is this logic performed elsewhere, I think we still want to do this? Could be missing something -- not super familiar with CoffeeScript :)
There was a problem hiding this comment.
Moved it to Subscriptions#create (see ~13 lines down in this PR). Before, Subscriptions#create constructed Subscription instances with a reference to @subscriptions and the subscription would then add itself to the collection. I'm not sure why I implemented that way originally. Now, Subscriptions#create makes a Subscription and then adds it to its collection.
In short: same end result, less confusing circular object passing.
There was a problem hiding this comment.
Ahh, gotcha. 👍 for less circular logic. :)
|
In general, 👍 for refactoring this a bit. |
|
❤️ |
ActionCable::INTERNALto ensure it stays synced withaction_cable.js(viaaction_cable.coffee.erb)ActionCable#getConfigto its original, intended design for reading anyaction-cable-*meta tag/cc @maclover7, @jeremy