Feature/active job test helper #27850
Conversation
|
Thanks for the pull request, and welcome! The Rails team is excited to review your changes, and you should hear from @rafaelfranca (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. This repository is being automatically checked for code quality issues using Code Climate. You can see results for this analysis in the PR status below. Newly introduced issues should be fixed before a Pull Request is considered ready to review. Please see the contribution instructions for more information. |
| @@ -1,3 +1,7 @@ | |||
| * Push skipped jobs to `enqueued_jobs` when using `perform_enqueued_jobs` with a `only` filter in tests | |||
|
|
|||
| *Alexander Pauly* | |||
There was a problem hiding this comment.
Needs two more spaces in this line
Refactored ActiveJob TestAdapter Updated ActiveJob changelog Fixed typo in changelog Fixed formatting issue in changelog
|
Thanks for pointing that out! I've fixed the formatting issue and squashed everything into a single commit |
Summary
This PR updates the
ActiveJob::QueueAdapters::TestAdapterto add filtered jobs to theenqueued_jobsarray. Prior to this change, skipped jobs were just ignored.Refer to #27848
Other Information
I've also updated the test suite.