Skip to content

Remove unnecessary package.json deletion #28941

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 1, 2017

Conversation

y-yagi
Copy link
Member

@y-yagi y-yagi commented May 1, 2017

@rails-bot
Copy link

r? @pixeltrix

(@rails-bot has picked a reviewer for you, use r? to override)

@y-yagi y-yagi closed this May 1, 2017
@y-yagi y-yagi reopened this May 1, 2017
@y-yagi
Copy link
Member Author

y-yagi commented May 1, 2017

Hmmm. It seems that the test unrelated to this change is falling.

  1) Failure:
ApplicationTests::BinSetupTest#test_bin_setup_output [test/application/bin_setup_test.rb:45]:
--- expected
+++ actual
@@ -1,11 +1,6 @@
 "== Installing dependencies ==
-The Gemfile's dependencies are satisfied
+ERROR:  While executing gem ... (Gem::UnsatisfiableDependencyError)
+    Unable to resolve dependency: user requested 'io-console (= 0.4.6)'
 
-== Preparing database ==
-Created database 'db/development.sqlite3'
-Created database 'db/test.sqlite3'
-
-== Removing old logs and tempfiles ==
-
-== Restarting application server ==
+== Command [\"gem install bundler --conservative\"] failed ==
 "
  2) Failure:
ApplicationTests::BinSetupTest#test_bin_setup [test/application/bin_setup_test.rb:30]:
Expected: 0
  Actual: 5 

@y-yagi
Copy link
Member Author

y-yagi commented May 1, 2017

The bin_setup_test.rb test passed by rubygems 2.6.11, but it falls in 2.6.12.

$ gem -v
2.6.11
$ ./bin/test -w test/application/bin_setup_test.rb
Run options: -w --seed 50496

# Running:

..

Finished in 10.729669s, 0.1864 runs/s, 0.6524 assertions/s.

2 runs, 7 assertions, 0 failures, 0 errors, 0 skips 
 
$ gem update --system 2.6.12
$ gem -v
2.6.12
$ ./bin/test -w test/application/bin_setup_test.rb
Run options: -w --seed 9481

# Running:

F

Failure:
ApplicationTests::BinSetupTest#test_bin_setup_output [/home/yaginuma/program/rails/master_y_yagi/rails/railties/test/application/bin_setup_test.rb:45]:
--- expected
+++ actual
@@ -1,11 +1,6 @@
 "== Installing dependencies ==
-The Gemfile's dependencies are satisfied
+ERROR:  While executing gem ... (Gem::UnsatisfiableDependencyError)
+    Unable to resolve dependency: user requested 'did_you_mean (= 1.1.0)'
 
-== Preparing database ==
-Created database 'db/development.sqlite3'
-Created database 'db/test.sqlite3'
-
-== Removing old logs and tempfiles ==
-
-== Restarting application server ==
+== Command [\"gem install bundler --conservative\"] failed ==
 "



bin/test test/application/bin_setup_test.rb:36

F

Failure:
ApplicationTests::BinSetupTest#test_bin_setup [/home/yaginuma/program/rails/master_y_yagi/rails/railties/test/application/bin_setup_test.rb:30]:
Expected: 0
  Actual: 5


bin/test test/application/bin_setup_test.rb:15



Finished in 2.730411s, 0.7325 runs/s, 1.8312 assertions/s.

2 runs, 5 assertions, 2 failures, 0 errors, 0 skips 

@rafaelfranca rafaelfranca merged commit eea4e8a into rails:master May 1, 2017
@rafaelfranca
Copy link
Member

Backported in fddf802

rafaelfranca added a commit that referenced this pull request May 1, 2017
Remove unnecessary `package.json` deletion
@y-yagi y-yagi deleted the remove_needless_remove_file branch May 1, 2017 20:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants