New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make `secrets:edit` run `secrets:setup` if it hasn't already. #29195

Merged
merged 2 commits into from May 25, 2017

Conversation

Projects
None yet
1 participant
@kaspth
Member

kaspth commented May 23, 2017

Fixes #29194.

Then also ditch the needless "waiting for edits" message.

  • See if we can't do people a solid and config.read_encrypted_secrets = true to their production.rb for them in case they haven't added it through app:update.
Remove needless waiting message.
Needed back when we attempted to wait for editors, but now we expect
users to pass a -w flag to their $EDITOR.

@kaspth kaspth added the railties label May 23, 2017

@kaspth kaspth added this to the 5.1.2 milestone May 23, 2017

@kaspth kaspth self-assigned this May 23, 2017

@kaspth

This comment has been minimized.

Show comment
Hide comment
@kaspth

kaspth May 23, 2017

Member

Going to go with @matthewd's suggestion of opening a new editor with the template file, then generate a key and encrypt the contents with that after the fact.

Member

kaspth commented May 23, 2017

Going to go with @matthewd's suggestion of opening a new editor with the template file, then generate a key and encrypt the contents with that after the fact.

@kaspth kaspth requested a review from matthewd May 23, 2017

Reorder first secrets edit flow.
Setup config/secrets.yml.enc with template contents for people to edit.

Then generate encryption key and encrypt the initial secrets.
@kaspth

This comment has been minimized.

Show comment
Hide comment
@kaspth

kaspth May 25, 2017

Member

Got the new editing flow up and running! Will merge + backport when green.

I'm going to pass on my extra credit task item for now so I can go work on #29180 (comment).

Though, contributors, feel free to fix it!

Member

kaspth commented May 25, 2017

Got the new editing flow up and running! Will merge + backport when green.

I'm going to pass on my extra credit task item for now so I can go work on #29180 (comment).

Though, contributors, feel free to fix it!

@kaspth kaspth merged commit 48f01f0 into rails:master May 25, 2017

2 checks passed

codeclimate no new or fixed issues
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@kaspth kaspth deleted the kaspth:rails-secrets-better-edit-exception branch May 25, 2017

kaspth added a commit that referenced this pull request May 25, 2017

Merge pull request #29195 from kaspth/rails-secrets-better-edit-excep…
…tion

Make `secrets:edit` run `secrets:setup` if it hasn't already.
@kaspth

This comment has been minimized.

Show comment
Hide comment
@kaspth

kaspth May 25, 2017

Member

Backported to 5-1-stable @ 157db87

Member

kaspth commented May 25, 2017

Backported to 5-1-stable @ 157db87

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment