Fix eager loading to respect store_full_sti_class setting
#29601
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Could you add a CHANGELOG entry? |
kamipo
force-pushed
the
fix_eager_loading_to_respect_store_full_sti_class
branch
from
3f93344 to
b084fe9
Compare
|
I added a CHANGELOG entry! |
rafaelfranca
added a commit
that referenced
this pull request
Jun 28, 2017
…ore_full_sti_class Fix eager loading to respect `store_full_sti_class` setting
kamipo
added a commit
to kamipo/rails
that referenced
this pull request
Feb 18, 2018
This is an alternative of rails#29722, and revert of rails#29601 and a1fcbd9. Currently, association creation and normal association finding doesn't respect `store_full_sti_class`. But eager loading and preloading respect the setting. This means that if set `store_full_sti_class = false` (`true` by default), eager loading and preloading can not find created polymorphic records. Association creation and finding should work consistently.
kamipo
added a commit
that referenced
this pull request
Feb 25, 2018
This is an alternative of #29722, and revert of #29601 and a1fcbd9. Currently, association creation and normal association finding doesn't respect `store_full_sti_class`. But eager loading and preloading respect the setting. This means that if set `store_full_sti_class = false` (`true` by default), eager loading and preloading can not find created polymorphic records. Association creation and finding should work consistently.
kamipo
added a commit
that referenced
this pull request
Feb 28, 2018
This is an alternative of #29722, and revert of #29601 and a1fcbd9. Currently, association creation and normal association finding doesn't respect `store_full_sti_class`. But eager loading and preloading respect the setting. This means that if set `store_full_sti_class = false` (`true` by default), eager loading and preloading can not find created polymorphic records. Association creation and finding should work consistently.
kamipo
added a commit
that referenced
this pull request
Feb 28, 2018
This has been removed in 7123c9b.
kamipo
added a commit
to kamipo/rails
that referenced
this pull request
Aug 23, 2020
This is an alternative of rails#29722. Before Rails 6.1, storing demodulized class name is supported only for STI type by `store_full_sti_class` class attribute. Now `store_full_class_name` class attribute can handle both STI and polymorphic types. Closes rails#29722. See also rails#29601, rails#32048, rails#32148.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.