Skip to content

Conversation

jules2689
Copy link
Contributor

@jules2689 jules2689 commented Jul 4, 2017

Summary

In #8234 we introduced a change that placed an upper bound on Bundler at 2.0

Bundler 2.0 is on the near horizon with a release expected later this year.

Previous reports claimed that there would be major changes, and while there are breaking changes (like the Gemfile.lock being totally rewritten), it does not block a Rails app from running.

Using Bundler master, I was able to enable Bundler 2.0 with all major deprecations, bundle install and require 'bundler/setup' via bin/rake environment without any issue whatsoever.

In preparation for Bundler 2.0 release, this PR removes that upper bound.

It is important to note that Bundler currently will print a warning but continue to run if you use Bundler 2.0 - so this isn't changing much except that a warning won't be printed.

cc @rafaelfranca

@rails-bot
Copy link

Thanks for the pull request, and welcome! The Rails team is excited to review your changes, and you should hear from @schneems (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

This repository is being automatically checked for code quality issues using Code Climate. You can see results for this analysis in the PR status below. Newly introduced issues should be fixed before a Pull Request is considered ready to review.

Please see the contribution instructions for more information.

@rafaelfranca rafaelfranca merged commit b115dd1 into rails:master Jul 4, 2017
rafaelfranca added a commit that referenced this pull request Jul 4, 2017
Allow the use of Bundler 2.0
rafaelfranca added a commit that referenced this pull request Jul 4, 2017
Allow the use of Bundler 2.0
benjaminwood added a commit to hintmedia/rails that referenced this pull request Oct 12, 2020
This change was made in Rails 5.0 and we're backporting it to make the
dual-boot upgrade easier to manage.

rails#29675
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants