Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow passing a Proc or Symbol as an argument to length validator values #30674

Merged

Conversation

@prognostikos
Copy link
Contributor

@prognostikos prognostikos commented Sep 21, 2017

This brings the Length validator in line with the Numericality validator, which currently supports Proc & Symbol arguments.

An example:

class Topic
  include ActiveModel::Validations

  attr_accessor :title, :foo

  validates :title, length: { maximum: ->(topic) { topic.max_length_for_title } }

  def max_length_for_title
    if foo
      5
    else
      10
  end
end
@rails-bot
Copy link

@rails-bot rails-bot commented Sep 21, 2017

Thanks for the pull request, and welcome! The Rails team is excited to review your changes, and you should hear from @pixeltrix (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

This repository is being automatically checked for code quality issues using Code Climate. You can see results for this analysis in the PR status below. Newly introduced issues should be fixed before a Pull Request is considered ready to review.

Please see the contribution instructions for more information.

@prognostikos
Copy link
Contributor Author

@prognostikos prognostikos commented Oct 25, 2017

I would love to get rid of my freedom patch for this feature - is there any chance this PR will be accepted? Any feedback is appreciated.

Copy link
Member

@rafaelfranca rafaelfranca left a comment

Could you add a CHANGELOG entry and squash your commits? I'll merge after that.

This brings the Length validator in line with the Numericality
validator, which currently supports Proc & Symbol arguments
@prognostikos prognostikos force-pushed the prognostikos:allow_procs_for_length_validator branch to b8b089e Oct 26, 2017
@prognostikos
Copy link
Contributor Author

@prognostikos prognostikos commented Oct 26, 2017

@rafaelfranca done, thanks for taking care of this.

@rafaelfranca rafaelfranca merged commit 12de5e2 into rails:master Oct 26, 2017
2 checks passed
2 checks passed
codeclimate All good!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@manojmj92
Copy link
Contributor

@manojmj92 manojmj92 commented Nov 26, 2019

Thanks for this change @prognostikos, this change helped me at work today! You are awesome! 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants