Allow passing a Proc or Symbol as an argument to length validator values #30674
Conversation
Thanks for the pull request, and welcome! The Rails team is excited to review your changes, and you should hear from @pixeltrix (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. This repository is being automatically checked for code quality issues using Code Climate. You can see results for this analysis in the PR status below. Newly introduced issues should be fixed before a Pull Request is considered ready to review. Please see the contribution instructions for more information. |
I would love to get rid of my freedom patch for this feature - is there any chance this PR will be accepted? Any feedback is appreciated. |
Could you add a CHANGELOG entry and squash your commits? I'll merge after that. |
This brings the Length validator in line with the Numericality validator, which currently supports Proc & Symbol arguments
b8b089e
@rafaelfranca done, thanks for taking care of this. |
Thanks for this change @prognostikos, this change helped me at work today! You are awesome! |
This brings the Length validator in line with the Numericality validator, which currently supports Proc & Symbol arguments.
An example: