New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Call Rails.ajax without beforeSend #31002

Merged
merged 1 commit into from Oct 30, 2017

Conversation

Projects
None yet
4 participants
@ta1kt0me
Contributor

ta1kt0me commented Oct 28, 2017

When we call Rails.ajax outside rails-ujs.js, we must define beforeSend even though it's empty function. I think Rails.ajax is not private api so it's more useful.

before

    Rails.ajax({
      type: 'get',
      url: '/',
      beforeSend: function() {
        return true
      },
      success: function() {
        // do something
      }

after

    Rails.ajax({
      type: 'get',
      url: '/',
      success: function() {
        // do something
      }
@rails-bot

This comment has been minimized.

Show comment
Hide comment
@rails-bot

rails-bot Oct 28, 2017

Thanks for the pull request, and welcome! The Rails team is excited to review your changes, and you should hear from @kaspth (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

This repository is being automatically checked for code quality issues using Code Climate. You can see results for this analysis in the PR status below. Newly introduced issues should be fixed before a Pull Request is considered ready to review.

Please see the contribution instructions for more information.

rails-bot commented Oct 28, 2017

Thanks for the pull request, and welcome! The Rails team is excited to review your changes, and you should hear from @kaspth (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

This repository is being automatically checked for code quality issues using Code Climate. You can see results for this analysis in the PR status below. Newly introduced issues should be fixed before a Pull Request is considered ready to review.

Please see the contribution instructions for more information.

@guilleiguaran guilleiguaran merged commit ee44c1b into rails:master Oct 30, 2017

2 checks passed

codeclimate All good!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@ta1kt0me ta1kt0me deleted the ta1kt0me:call_ajax_without_beforeSend branch Oct 30, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment