Skip to content

Conversation

lanzhiheng
Copy link
Contributor

@lanzhiheng lanzhiheng commented Jul 16, 2018

Summary

As you can see, just use the fixed-width font will not be markedness about the code. I think we can use another color to make it clearer.

Other Information

image

@twitnithegirl
Copy link
Contributor

I think this is a lot more readable.

@matthewd
Copy link
Member

We're already using (a darker shade of) red to indicate links... using it for something non-clickable seems likely to confuse.

In our recent restyling of the API docs, we adopted a GitHub style background effect:

image

What do you think of adopting something closer to that? (Maybe even with a special yellowish variant in note blocks?)

@lanzhiheng lanzhiheng force-pushed the change-the-text-color-which-wrapped-by-code-tag branch from e3662bb to 5b88ffd Compare July 17, 2018 06:14
@lanzhiheng
Copy link
Contributor Author

@matthewd Thanks for your comments. I have changed the code, I use the #fff for code wrapped's background in the note, info, and todo section. And use #eee in normal text area. You can see the effect from the screenshot in PR. Is it OK now?

@lanzhiheng lanzhiheng force-pushed the change-the-text-color-which-wrapped-by-code-tag branch from 5b88ffd to 6ad5867 Compare July 19, 2018 01:50
@eileencodes eileencodes merged commit bd139a5 into rails:master Jul 23, 2018
@lanzhiheng lanzhiheng deleted the change-the-text-color-which-wrapped-by-code-tag branch July 24, 2018 08:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants