Log the remote IP addr of clients behind a proxy #33489
Conversation
|
Thanks for the pull request, and welcome! The Rails team is excited to review your changes, and you should hear from @georgeclaghorn (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. This repository is being automatically checked for code quality issues using Code Climate. You can see results for this analysis in the PR status below. Newly introduced issues should be fixed before a Pull Request is considered ready to review. Please see the contribution instructions for more information. |
There was a problem hiding this comment.
Do you mind if I ask you to update commit message to add credit, based on the name in https://patch-diff.githubusercontent.com/raw/rails/rails/pull/24521.patch and force push to this branch?
It should read:
Log the remote IP addr of clients behind a proxy.
[Atul Bhosale, Victor Nawothnig]
That way you both will get credited on our contributors site.
Thank you very much.
[Atul Bhosale, Victor Nawothnig]
|
@sikachu done, I have updated it. Is it correct? |
Log the remote IP addr of clients behind a proxy
|
@sikachu @georgeclaghorn Thank you. This was my first PR to rails :) |
When Rails is behind a proxy server, REMOTE_ADDR will be the IP of the proxy rather than the user's actual IP. The `request.remote_ip` method properly accounts for this. See rails/rails#33489 for a similar change in Rails.
If Rails is behind a proxy server, the log will show the IP address of the proxy for each request, rather than the remote IP address. I feel that this information is rarely if ever useful.
My change makes the logger use request.remote_ip, which makes a smart guess at the remote IP address by considering CLIENT_IP / X_FORWARDED_FOR and checking against the list of trusted proxies.
Closes #7979