Use public_send in value_for_collection

[Ana06]

Deprecate use of private methods in view's helpers. We should start calling public_send in value_for_collection instead of send to void exposing private methods in view's helpers.

Fixes #33546

[rails-bot]

Thanks for the pull request, and welcome! The Rails team is excited to review your changes, and you should hear from @georgeclaghorn (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

This repository is being automatically checked for code quality issues using Code Climate. You can see results for this analysis in the PR status below. Newly introduced issues should be fixed before a Pull Request is considered ready to review.

Please see the contribution instructions for more information.

[matthewd]

Hi!

I agree we should change this. (And the other send I spotted a few lines above.)

If it's worth fixing, it's worth keeping fixed, so we should add a test too.

My big question-mark, however, is whether we need a deprecation. Much as public_send is a far more sensible choice, it seems likely someone is currently, perhaps inadvertently, relying on the fact we call private methods. @rafaelfranca?

[rafaelfranca]

Agree. It is safer if we deprecate it.

[Ana06]

@matthewd

And the other send I spotted a few lines above.

👍

If it's worth fixing, it's worth keeping fixed, so we should add a test too.

I'll add it 😉

@matthewd @rafaelfranca regarding the deprecation, I guess you mean showing a message in case that the method used is private and not to deprecate the method itself, right?

[matthewd]

Right. I think we'd do it something like this:

begin
  item.public_send(value)
rescue NoMethodError
  if item.respond_to?(value, true) && !item.respond_to?(value)
    ActiveSupport::Deprecation "Hey don't do that"
    item.send(value)
  else
    raise
  end
end

[Ana06]

I think at least 0c62e14 should be rebased into 87b6e6a, but I left it like that following @rails-bot instructions:

If any changes to this PR are deemed necessary, please add them as extra commits.

[Ana06]

@matthewd @rafaelfranca I think the changes are addressed, please take a look. 🙏 Do we need to test other view's helpers or is it enough with testing options_from_collection_for_select? 🤔

[georgeclaghorn]

r? @matthewd

[Ana06]

@matthewd something else to change? 🤔

[matthewd]

Nope, this is great, thanks! ❤️

I made a few of tweaks in the merge commit, FYI: 047a893 (changelog formatting, and I added the name of the called private method to the deprecation message)

[Ana06]

@matthewd

I made a few of tweaks in the merge commit, FYI: 047a893 (changelog formatting, and I added the name of the called private method to the deprecation message)

I could have made the changes, now my name is not in the commit anymore 😭 😭 😭

[matthewd]

@Ana06 all your commits are in there: https://contributors.rubyonrails.org/contributors/ana-maria-martinez-gomez/commits (Oops.. if I'd seen there were so many I should've gotten you to squash. Oh well. 🤷🏻‍♂️)

[Ana06]

@matthewd

@Ana06 all your commits are in there: https://contributors.rubyonrails.org/contributors/ana-maria-martinez-gomez/commits (Oops.. if I'd seen there were so many I should've gotten you to squash. Oh well. 🤷🏻‍♂️)

you are right, sorry 🙈 I though you squashed the commits, because they needed to be squashed and I didn't see them in the commits history. It seems it is a different way to merge things (withour rebasing) and I didn't see them 👀

Thanks for merging it 😉

[matthewd]

No worries, thanks for the work! (It's an ordinary merge, but that means your commits are further down the list [currently on page 5 by my count], based on their commit date, even though they only just hit master.)

[Ana06]

@matthewd @rafaelfranca I spoke about this PR in my talk at EuRuKo (in front of around ~550 people), maybe you want to watch it: https://youtu.be/jUc8InwoA-E?t=2m54s 😉

The part where I speak about this is almost as the end, but I am not sure if it is possible to follow without watching the whole talk. 🤔 It is anyway not that long! only 25 minutes 😄